ci: Fixing Spanner CDC correctness tests and correcting the Failure injection tests workflow#3781
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3781 +/- ##
============================================
+ Coverage 53.29% 53.47% +0.18%
- Complexity 6575 6656 +81
============================================
Files 1079 1085 +6
Lines 65576 66441 +865
Branches 7301 7399 +98
============================================
+ Hits 34948 35532 +584
- Misses 28277 28514 +237
- Partials 2351 2395 +44
🚀 New features to boost your workflow:
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the reliability and correctness of Spanner CDC and SourceDB failure injection tests. By introducing a fixed job start time for the injection policy, the system avoids issues where worker restarts cause inconsistent failure windows. Additionally, the PR standardizes worker configurations and updates the CI pipeline to ensure these tests are correctly triggered. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a consistent jobStartTime for failure injection tests to prevent infinite restart loops on Dataflow workers and updates CI/CD configurations to include these tests. It also standardizes the workerMachineType to n2-standard-4 for several integration tests. Review feedback focuses on improving code maintainability by using String.format for JSON string construction and utilizing local variables to avoid redundant calls when parsing input parameters.
Successful runs: