Skip to content

ci: Fixing Spanner CDC correctness tests and correcting the Failure injection tests workflow#3781

Merged
darshan-sj merged 7 commits into
mainfrom
spanner-ft
May 12, 2026
Merged

ci: Fixing Spanner CDC correctness tests and correcting the Failure injection tests workflow#3781
darshan-sj merged 7 commits into
mainfrom
spanner-ft

Conversation

@darshan-sj

@darshan-sj darshan-sj commented May 11, 2026

Copy link
Copy Markdown
Contributor

@darshan-sj darshan-sj requested a review from a team as a code owner May 11, 2026 08:35
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.47%. Comparing base (00cd31f) to head (23f962f).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...reinjection/TransactionTimeoutInjectionPolicy.java 0.00% 6 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3781      +/-   ##
============================================
+ Coverage     53.29%   53.47%   +0.18%     
- Complexity     6575     6656      +81     
============================================
  Files          1079     1085       +6     
  Lines         65576    66441     +865     
  Branches       7301     7399      +98     
============================================
+ Hits          34948    35532     +584     
- Misses        28277    28514     +237     
- Partials       2351     2395      +44     
Components Coverage Δ
spanner-templates 72.79% <ø> (+<0.01%) ⬆️
spanner-import-export 68.52% <ø> (ø)
spanner-live-forward-migration 80.93% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 77.08% <ø> (+0.01%) ⬆️
spanner-bulk-migration 91.10% <ø> (-0.01%) ⬇️
gcs-spanner-dv 85.74% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...reinjection/TransactionTimeoutInjectionPolicy.java 76.66% <0.00%> (-10.13%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the reliability and correctness of Spanner CDC and SourceDB failure injection tests. By introducing a fixed job start time for the injection policy, the system avoids issues where worker restarts cause inconsistent failure windows. Additionally, the PR standardizes worker configurations and updates the CI pipeline to ensure these tests are correctly triggered.

Highlights

  • Failure Injection Policy Enhancement: Introduced a 'jobStartTime' parameter to the TransactionTimeoutInjectionPolicy to ensure consistent failure injection windows across Dataflow workers, preventing potential infinite restart loops during long-duration tests.
  • Test Infrastructure Updates: Updated Spanner CDC and SourceDB failure injection tests to pass the 'jobStartTime' parameter and standardized worker machine types to 'n2-standard-4' for more reliable test execution.
  • CI Workflow Improvement: Updated the failure injection test runner script to include the necessary Maven flags for executing these tests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a consistent jobStartTime for failure injection tests to prevent infinite restart loops on Dataflow workers and updates CI/CD configurations to include these tests. It also standardizes the workerMachineType to n2-standard-4 for several integration tests. Review feedback focuses on improving code maintainability by using String.format for JSON string construction and utilizing local variables to avoid redundant calls when parsing input parameters.

@darshan-sj darshan-sj merged commit ae76236 into main May 12, 2026
47 checks passed
@darshan-sj darshan-sj deleted the spanner-ft branch May 12, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants