Skip to content

feat: integrate CommonTemplateJvmInitializer for SSL certificate staging in SpannerToSourceDb pipeline.#3910

Merged
pratickchokhani merged 2 commits into
GoogleCloudPlatform:mainfrom
pratickchokhani:rr-ssl-cassandra
Jun 18, 2026
Merged

feat: integrate CommonTemplateJvmInitializer for SSL certificate staging in SpannerToSourceDb pipeline.#3910
pratickchokhani merged 2 commits into
GoogleCloudPlatform:mainfrom
pratickchokhani:rr-ssl-cassandra

Conversation

@pratickchokhani

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.58%. Comparing base (3c54627) to head (0766b7b).

Files with missing lines Patch % Lines
...cloud/teleport/v2/templates/SpannerToSourceDb.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3910      +/-   ##
============================================
+ Coverage     55.56%   55.58%   +0.01%     
+ Complexity     7048     6599     -449     
============================================
  Files          1103     1103              
  Lines         67681    67682       +1     
  Branches       7603     7603              
============================================
+ Hits          37607    37618      +11     
+ Misses        27652    27641      -11     
- Partials       2422     2423       +1     
Components Coverage Δ
spanner-templates 88.48% <0.00%> (-0.02%) ⬇️
spanner-import-export 68.67% <ø> (+0.11%) ⬆️
spanner-live-forward-migration 90.23% <ø> (-0.02%) ⬇️
spanner-live-reverse-replication 84.41% <0.00%> (-0.03%) ⬇️
spanner-bulk-migration 92.62% <ø> (-0.01%) ⬇️
gcs-spanner-dv 88.88% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...cloud/teleport/v2/templates/SpannerToSourceDb.java 19.46% <0.00%> (-0.06%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pratickchokhani pratickchokhani force-pushed the rr-ssl-cassandra branch 7 times, most recently from c6d60b9 to 89c1bed Compare June 17, 2026 09:10
@pratickchokhani pratickchokhani marked this pull request as ready for review June 17, 2026 09:10
@pratickchokhani pratickchokhani requested a review from a team as a code owner June 17, 2026 09:10
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enables SSL/TLS support for the SpannerToSourceDb pipeline by integrating the CommonTemplateJvmInitializer. It also significantly upgrades the integration testing infrastructure by providing a wrapper for Cassandra containers that automatically handles certificate generation and SSL configuration, ensuring that secure connectivity can be validated in test environments.

Highlights

  • SSL Support Integration: Integrated CommonTemplateJvmInitializer into the SpannerToSourceDb pipeline to enable staging of SSL certificates via extraFiles.
  • Test Infrastructure Update: Introduced CassandraSslContainerWrapper to support automated testing of Cassandra instances with SSL/TLS encryption enabled.
  • Integration Test Enhancements: Updated SpannerToCassandraSourceDbIT to utilize the new SSL-enabled container wrapper and configure pipeline parameters for secure connections.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates SSL/TLS encryption for Cassandra in the Spanner-to-SourceDb template. It introduces CassandraSslContainerWrapper to spin up a Cassandra container with SSL enabled, updates the integration tests to use this wrapper, and configures the Dataflow pipeline to stage the generated truststore. The review feedback focuses on improving the robustness of the container wrapper by properly handling InterruptedException during process execution, inheriting process I/O to aid in debugging keytool failures, and cleaning up temporary keystore and truststore files upon teardown.

VardhanThigle
VardhanThigle previously approved these changes Jun 17, 2026

@VardhanThigle VardhanThigle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
Please wait for ITs to pass before merging.

@pratickchokhani pratickchokhani merged commit aed1104 into GoogleCloudPlatform:main Jun 18, 2026
31 of 33 checks passed
@pratickchokhani pratickchokhani deleted the rr-ssl-cassandra branch June 18, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants