feat: integrate CommonTemplateJvmInitializer for SSL certificate staging in SpannerToSourceDb pipeline.#3910
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3910 +/- ##
============================================
+ Coverage 55.56% 55.58% +0.01%
+ Complexity 7048 6599 -449
============================================
Files 1103 1103
Lines 67681 67682 +1
Branches 7603 7603
============================================
+ Hits 37607 37618 +11
+ Misses 27652 27641 -11
- Partials 2422 2423 +1
🚀 New features to boost your workflow:
|
c6d60b9 to
89c1bed
Compare
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enables SSL/TLS support for the SpannerToSourceDb pipeline by integrating the CommonTemplateJvmInitializer. It also significantly upgrades the integration testing infrastructure by providing a wrapper for Cassandra containers that automatically handles certificate generation and SSL configuration, ensuring that secure connectivity can be validated in test environments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request integrates SSL/TLS encryption for Cassandra in the Spanner-to-SourceDb template. It introduces CassandraSslContainerWrapper to spin up a Cassandra container with SSL enabled, updates the integration tests to use this wrapper, and configures the Dataflow pipeline to stage the generated truststore. The review feedback focuses on improving the robustness of the container wrapper by properly handling InterruptedException during process execution, inheriting process I/O to aid in debugging keytool failures, and cleaning up temporary keystore and truststore files upon teardown.
VardhanThigle
left a comment
There was a problem hiding this comment.
looks good to me.
Please wait for ITs to pass before merging.
cd5bae2 to
89c1bed
Compare
…ing in SpannerToSourceDb pipeline
…ntegration testing for SpannerToCassandra template
89c1bed to
0766b7b
Compare
aed1104
into
GoogleCloudPlatform:main
No description provided.