Skip to content

test(internal/bufferedread): fix flaky TestReadAtBackwardSeekIsRandomRead #4791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kislaykishore merged 1 commit into from
Jun 19, 2026
Merged

test(internal/bufferedread): fix flaky TestReadAtBackwardSeekIsRandomRead #4791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/bufferedread/buffered_reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,13 @@ func (t *BufferedReaderTest) TestReadAtBackwardSeekIsRandomRead() {
assert.Equal(t.T(), int64(2), reader.randomSeekCount, "Second read should be counted as random.")
assert.Equal(t.T(), 2, reader.blockQueue.Len(), "Queue should contain newly prefetched blocks.")
assertReadResponseContent(t.T(), resp, 0)
// Wait for the async prefetch tasks to complete to verify the mock calls.
bqe1 := reader.blockQueue.Pop()
bqe2 := reader.blockQueue.Pop()
_, err = bqe1.block.AwaitReady(t.ctx)
require.NoError(t.T(), err, "AwaitReady for block 1 failed")
_, err = bqe2.block.AwaitReady(t.ctx)
require.NoError(t.T(), err, "AwaitReady for block 2 failed")
t.bucket.AssertExpectations(t.T())
}

Expand Down
Loading