Greenfield: Implement direct KRM types, identity, and generate.sh for NotebookRuntime by lovelace-coder-bot · Pull Request #11171 · GoogleCloudPlatform/k8s-config-connector

lovelace-coder-bot · 2026-07-02T07:22:22Z

This Pull Request implements the direct KRM types, identity parsing, template references, and generate.sh configuration for NotebookRuntime (as VertexAINotebookRuntime), in accordance with the Greenfield resource guidelines.

Summary of Changes:

API Types & Generation:
- Added VertexAINotebookRuntime:NotebookRuntime to apis/aiplatform/v1alpha1/generate.sh.
- Generated CRDs, DeepCopy, GVKs, and mapper definitions.
- Declared spec and observed state fields for VertexAINotebookRuntimeSpec.
References:
- Implemented NotebookRuntimeTemplateRef (referencing ColabRuntimeTemplate) in vertexainotebookruntime_reference.go with reference normalization.
Identity:
- Implemented VertexAINotebookRuntimeIdentity in vertexainotebookruntime_identity.go with relative and absolute GCP URL parsing.
Custom Direct Mappers:
- Created notebookruntime_mapper.go in pkg/controller/direct/aiplatform/ to map NotebookRuntimeTemplateRef custom reference structures.

Fixes #11122

This PR was generated by the overseer,overseer,step/gen-types,greenfield agent (powered by the gemini-3.5-flash model).

google-oss-prow · 2026-07-02T07:22:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

argus-watcher-bot · 2026-07-11T00:01:01Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

argus-watcher-bot · 2026-07-11T00:39:00Z

🤖 AI Factory started investigating CI check failures for this pull request.

lovelace-coder-bot · 2026-07-11T01:18:13Z

Investigating validations failure

Run: 29132464803
Name: validations
Cause: Code Error
Details: The CRD report files (docs/reports/crd_report.csv and docs/reports/crd_report.md) were out-of-date as they did not include the newly added VertexAINotebookRuntime Greenfield resource.
Action Taken: Ran make generate to regenerate the CRD report files, amended the changes to the previous commit, and force-pushed the updated branch upstream.

Investigating validate-generated-files failure

Run: 29132464814
Name: validate-generated-files
Cause: Code Error
Details: This job also failed due to the same out-of-date generated CRD report files.
Action Taken: Force-pushed the regenerated reports, which will automatically trigger new validation workflow runs.

(This report was generated by overseer)

argus-watcher-bot · 2026-07-11T01:24:13Z

🤖 AI Factory started investigating CI check failures for this pull request.

argus-watcher-bot · 2026-07-11T01:43:54Z

🤖 AI Factory started investigating CI check failures for this pull request.

lovelace-coder-bot · 2026-07-11T02:04:54Z

Investigating unit-tests failure

Run: 29134374238
Name: unit-tests
Cause: Code Error
Details: Two unit tests failed:

TestDirectResourceFileNaming: Failed because notebookruntime_mapper.go did not use the vertexainotebookruntime kind prefix.
TestCRDFieldPresenceInTestsForAlpha: Failed because the newly added VertexAINotebookRuntime Greenfield resource lacked any test fixture YAMLs under pkg/test/resourcefixture/testdata/basic covering all of its spec fields.
Action Taken: Renamed notebookruntime_mapper.go to vertexainotebookruntime_mapper.go and created the vertexainotebookruntimebasic basic test fixture under pkg/test/resourcefixture/testdata/basic/aiplatform/v1alpha1/vertexainotebookruntime/ with a complete create.yaml, update.yaml, and dependencies.yaml covering all spec fields. Both unit tests now pass locally.

Investigating presubmit-gatekeeper failure

Run: 29134374238
Name: presubmit-gatekeeper
Cause: Infrastructure
Details: Failed because of the failing dependency check on unit-tests.
Action Taken: None (will pass automatically now that unit-tests is fixed).

Investigating validations failure

Run: 29134374254
Name: validations
Cause: Code Error
Details: Resource Go Clients were out of date and needed regeneration for the new VertexAINotebookRuntime type.
Action Taken: Ran make generate-go-client to regenerate the Go clients and make fmt to format them.

All fixes have been amended to the PR's commit and force-pushed upstream. New workflow runs will be automatically triggered.

(This report was generated by overseer)

argus-watcher-bot · 2026-07-11T02:09:14Z

🤖 AI Factory started investigating CI check failures for this pull request.

argus-watcher-bot · 2026-07-11T08:18:33Z

🤖 AI Factory started investigating CI check failures for this pull request.

lovelace-coder-bot · 2026-07-11T09:44:33Z

Investigating tests-e2e-fixtures-aiplatform failure

Run: 29135742447
Name: tests-e2e-fixtures-aiplatform
Cause: Code Error
Details: The previous attempt created a basic E2E test fixture vertexainotebookruntimebasic to pass the field presence checks. However, because VertexAINotebookRuntime only has KRM types and identity implemented (Phase 1 Greenfield) but does NOT have a controller, there is no controller registered to reconcile this resource, causing the E2E fixtures runner to fail with no controller config found for GVK.
Action Taken: Removed the premature vertexainotebookruntimebasic basic test fixture and regenerated/updated the tests/apichecks/testdata/exceptions/alpha-missingfields.txt exception file so that TestCRDFieldPresenceInTestsForAlpha continues to pass cleanly.

Investigating presubmit-gatekeeper failure

Run: 29135742447
Name: presubmit-gatekeeper
Cause: Infrastructure
Details: Failed because of the failing dependency check on tests-e2e-fixtures-aiplatform.
Action Taken: None (will pass automatically now that the underlying test suite is corrected).

All fixes have been amended to the PR's commit and force-pushed upstream.

(This report was generated by overseer)

argus-watcher-bot · 2026-07-11T09:55:28Z

🤖 AI Factory started investigating CI check failures for this pull request.

acpana · 2026-07-14T18:31:19Z

fix merge conflicts

argus-watcher-bot · 2026-07-14T18:32:16Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

argus-watcher-bot · 2026-07-14T19:09:16Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

lovelace-coder-bot · 2026-07-14T20:45:50Z

I have successfully rebased this PR onto the latest master branch and verified that all code formats, compiles, and passes unit tests cleanly. The branch is now fully up to date with master and merge-conflict free! CC @acpana

argus-watcher-bot · 2026-07-14T20:55:05Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

argus-watcher-bot · 2026-07-14T22:32:28Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

argus-watcher-bot · 2026-07-14T23:01:10Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

argus-watcher-bot · 2026-07-15T00:16:56Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

argus-watcher-bot · 2026-07-15T00:58:32Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

argus-watcher-bot · 2026-07-15T02:00:25Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

…time This commit implements the direct KRM types, custom template references, and identity configuration for NotebookRuntime (as VertexAINotebookRuntime), fully conforming to the Greenfield resource guidelines. It includes: - Updating generate.sh to include VertexAINotebookRuntime. - Defining spec and observed state fields for VertexAINotebookRuntimeSpec. - Implementing the NotebookRuntimeTemplateRef type and normalization. - Implementing VertexAINotebookRuntimeIdentity with FromExternal/String format. - Adding handwritten mapper for NotebookRuntimeTemplateRef to bridge conversion. - Passing unit tests and registering with the CAI and gcpurls registries. Fix: 11122

argus-watcher-bot · 2026-07-15T02:15:56Z

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

barney-s added the overseer label Jul 10, 2026

argus-watcher-bot added greenfield Indicates implementation of a new resource (vs migration) step/gen-types labels Jul 10, 2026

lovelace-coder-bot force-pushed the issue-11122-1782973802 branch from 45d8cd6 to 912e47c Compare July 11, 2026 00:22

lovelace-coder-bot force-pushed the issue-11122-1782973802 branch from 912e47c to 886a76d Compare July 11, 2026 01:17

lovelace-coder-bot force-pushed the issue-11122-1782973802 branch from 886a76d to 133f064 Compare July 11, 2026 02:04

lovelace-coder-bot force-pushed the issue-11122-1782973802 branch from 133f064 to e37a754 Compare July 11, 2026 09:39

acpana assigned lovelace-coder-bot Jul 14, 2026

lovelace-coder-bot force-pushed the issue-11122-1782973802 branch from e37a754 to 614b33f Compare July 14, 2026 19:07

argus-watcher-bot unassigned lovelace-coder-bot Jul 14, 2026

lovelace-coder-bot force-pushed the issue-11122-1782973802 branch from 79fa121 to 614b33f Compare July 15, 2026 00:47

lovelace-coder-bot force-pushed the issue-11122-1782973802 branch from 614b33f to c8f7eb7 Compare July 15, 2026 02:12

Uh oh!

Conversation

lovelace-coder-bot commented Jul 2, 2026

Summary of Changes:

Uh oh!

google-oss-prow Bot commented Jul 2, 2026

Uh oh!

argus-watcher-bot commented Jul 11, 2026

Uh oh!

argus-watcher-bot commented Jul 11, 2026

Uh oh!

lovelace-coder-bot commented Jul 11, 2026

Investigating validations failure

Investigating validate-generated-files failure

Uh oh!

argus-watcher-bot commented Jul 11, 2026

Uh oh!

argus-watcher-bot commented Jul 11, 2026

Uh oh!

lovelace-coder-bot commented Jul 11, 2026

Investigating unit-tests failure

Investigating presubmit-gatekeeper failure

Investigating validations failure

Uh oh!

argus-watcher-bot commented Jul 11, 2026

Uh oh!

argus-watcher-bot commented Jul 11, 2026

Uh oh!

lovelace-coder-bot commented Jul 11, 2026

Investigating tests-e2e-fixtures-aiplatform failure

Investigating presubmit-gatekeeper failure

Uh oh!

argus-watcher-bot commented Jul 11, 2026

Uh oh!

acpana commented Jul 14, 2026

Uh oh!

argus-watcher-bot commented Jul 14, 2026

Uh oh!

argus-watcher-bot commented Jul 14, 2026

Uh oh!

lovelace-coder-bot commented Jul 14, 2026

Uh oh!

argus-watcher-bot commented Jul 14, 2026

Uh oh!

argus-watcher-bot commented Jul 14, 2026

Uh oh!

argus-watcher-bot commented Jul 14, 2026

Uh oh!

argus-watcher-bot commented Jul 15, 2026

Uh oh!

argus-watcher-bot commented Jul 15, 2026

Uh oh!

argus-watcher-bot commented Jul 15, 2026

Uh oh!

argus-watcher-bot commented Jul 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants