Implement the new klog and logfmt structured log parser#359
Merged
kyasbal merged 4 commits intoNov 13, 2025
Conversation
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new, more performant parsers for klog and logfmt structured logs, moving the old implementation to a legacyklog file. The new parsers leverage sync.Pool and strings.Builder for efficiency. The changes are well-structured, with common types extracted into a new type.go file and comprehensive tests including benchmarks.
My review includes a few suggestions to improve maintainability and robustness:
- Decoupling the
legacyklogparser from thelogfmtparser. - Ensuring consistent and safe usage of
sync.Pool. - Improving test file organization.
…g parsers with the new implementation
kkuchima
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change part of #357.
This PR introduces new string formatted structured logging parsers.
The previous implementations were renamed to
legacyklogand it had problems:The new implementation introduced in this PR uses
strings.Builderto parse and usessync.Poolto use them efficiently.