Fix the flaky end time input form default value issue#360
Merged
Conversation
Member
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively resolves a flakiness issue in the end time input form by introducing a stable inspectionCreationTime. This time is captured once when the InspectionTaskRunner is created and propagated via the context. This is a solid approach to ensure deterministic behavior, especially for tests. The changes are well-implemented across the runner, context keys, task logic, and tests. I have one minor suggestion to improve code documentation in the test utilities.
kyasbal
requested review from
RyuSA,
jyane,
kkuchima and
yfuruyama
as code owners
kkuchima
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input form field was unintentionally updated for every secounds and it can lose user's selection and affected usability.