Skip to content

Add task IDs, types used in task output, new revision state types and README about the new k8saudit tasks#384

Merged
kyasbal merged 15 commits into
GoogleCloudPlatform:epic/issue-373from
kyasbal:epic/issue-373-contracts
Dec 2, 2025
Merged

Add task IDs, types used in task output, new revision state types and README about the new k8saudit tasks#384
kyasbal merged 15 commits into
GoogleCloudPlatform:epic/issue-373from
kyasbal:epic/issue-373-contracts

Conversation

@kyasbal

@kyasbal kyasbal commented Dec 2, 2025

Copy link
Copy Markdown
Member

This is the changes related to commonlogk8sauditv2_contract used by the implementations pushed later.

The last task graph used in commonlogk8sauditv2 will be following:

Each history modifier tasks are dependent from tasks defined for clusters.

graph TD
    %% External Dependencies
    Provider[K8sAuditLogProviderRef]
    MergeConfig[K8sResourceMergeConfigTask]

    classDef external stroke-dasharray: 5 5;
    class Provider,MergeConfig external;

    Serializer[K8sAuditLogSerializerTask]
    SuccessFilter[SuccessLogFilterTask]
    NonSuccessFilter[NonSuccessLogFilterTask]
    LogSorter[LogSorterTask]
    
    %% Groupers
    LogSummaryGrouper[LogSummaryGrouperTask]
    NonSuccessGrouper[NonSuccessLogGrouperTask]
    ChangeTargetGrouper[ChangeTargetGrouperTask]
    
    %% Manifest & Lifetime
    ManifestGenerator[ManifestGeneratorTask]
    LifetimeTracker[ResourceLifetimeTrackerTask]
    
    %% History Modifiers
    NamespaceRequestHM[NamespaceRequestHistoryModifierTask]
    LogSummaryHM[LogSummaryHistoryModifierTask]
    NonSuccessHM[NonSuccessLogHistoryModifierTask]
    RevisionHM[ResourceRevisionHistoryModifierTask]
    OwnerRefHM[ResourceOwnerReferenceModifierTask]
    EndpointHM[EndpointResourceHistoryModifierTask]
    PodPhaseHM[PodPhaseHistoryModifierTask]
    ContainerHM[ContainerHistoryModifierTask]
    ConditionHM[ConditionHistoryModifierTask]

    %% Connections
    Provider --> Serializer
    Provider --> SuccessFilter
    Provider --> NonSuccessFilter
    Provider --> LogSummaryGrouper
    
    SuccessFilter --> LogSorter
    NonSuccessFilter --> NonSuccessGrouper
    
    LogSorter --> ChangeTargetGrouper
    
    ChangeTargetGrouper --> ManifestGenerator
    MergeConfig --> ManifestGenerator
    
    ManifestGenerator --> LifetimeTracker
    Serializer --> LifetimeTracker

    ManifestGenerator --> NamespaceRequestHM
    Serializer --> NamespaceRequestHM
    
    %% Modifiers dependencies
    LogSummaryGrouper --> LogSummaryHM
    Serializer --> LogSummaryHM
    
    NonSuccessGrouper --> NonSuccessHM
    Serializer --> NonSuccessHM
    
    LifetimeTracker --> RevisionHM
    Serializer --> RevisionHM
    
    LifetimeTracker --> OwnerRefHM
    Serializer --> OwnerRefHM
    
    LifetimeTracker --> EndpointHM
    Serializer --> EndpointHM
    
    LifetimeTracker --> PodPhaseHM
    Serializer --> PodPhaseHM
    
    LifetimeTracker --> ContainerHM
    Serializer --> ContainerHM
    
    LifetimeTracker --> ConditionHM
    Serializer --> ConditionHM
Loading

@kyasbal kyasbal added enhancement New feature or request backend:parser labels Dec 2, 2025
@kyasbal kyasbal force-pushed the epic/issue-373-contracts branch 3 times, most recently from 2c13d75 to 254108b Compare December 2, 2025 03:06
* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs
…from Cloud Logging (GoogleCloudPlatform#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist
* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs
* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs
…and resourcepaths

This commit includes contract related changes of the later task implementations.
@kyasbal kyasbal force-pushed the epic/issue-373-contracts branch from 254108b to e340932 Compare December 2, 2025 03:10
@kyasbal

kyasbal commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant set of changes related to the commonlogk8sauditv2 contract, including new task IDs, data types, and revision states, to support a new task graph for processing Kubernetes audit logs. A detailed README file has been added, which is a great addition for maintainability. The code is generally well-structured. However, I've identified a critical issue in the newly added parsing logic that could lead to a panic, and a minor formatting issue in the new README file. Addressing these points will improve the robustness and clarity of the implementation.

Comment thread pkg/task/inspection/googlecloudlogk8saudit/impl/fieldset.go
Comment thread pkg/task/inspection/commonlogk8sauditv2/README.md Outdated
@kyasbal kyasbal force-pushed the epic/issue-373-contracts branch from f20a502 to eb47476 Compare December 2, 2025 03:30
@kyasbal kyasbal marked this pull request as ready for review December 2, 2025 03:30
@kyasbal kyasbal merged commit eae4248 into GoogleCloudPlatform:epic/issue-373 Dec 2, 2025
7 of 8 checks passed
kyasbal added a commit that referenced this pull request Dec 4, 2025
…types (#399)

* feat: Dynamically generate Cloud Logging resource name input forms based on active tasks in the task graph. (#374) (#376)

* feat: Dynamically generate Cloud Logging resource name input forms based on active tasks in the task graph.

This is a fix of bug input forms weren't disappeared once it was added even a feature requesting it was turned off.

* fix issue pointed by gemini-code-assist

* Adding several minor changes to improve testability before migrating the existing k8s audit parser to the new audit parser (#375)

* Added NewLogSorterByTimeTask and test utilities for inspectiontaskbase package

* feat: Show orphaned log when no parser associated the log to any timeline and add namespace level timeline

* fix issues pointed out by gemini-code-assist

* Adding tasks for log summary generation and history modifier for error audit logs (#377)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding tasks related to merge manifests from audit logs (#379)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Add ManifestGenerator related tasks

* fix issues pointed by gemini-code-assist

* Adding testchangeset utility (#382)

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Fix flaky test on commonk8slogaudit tasks (#388)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Adding new type definitions in contract, enum values of history data and resourcepaths

This commit includes contract related changes of the later task implementations.

* fix issue pointed by gemini-code-assist

* fix flaky test because of string list order

* Add task IDs, types used in task output, new revision state types and README about the new  k8saudit tasks (#384)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Adding new type definitions in contract, enum values of history data and resourcepaths

This commit includes contract related changes of the later task implementations.

* fix issue pointed by gemini-code-assist

* Revision sort criteria wasn't right (#386)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Adding new type definitions in contract, enum values of history data and resourcepaths

This commit includes contract related changes of the later task implementations.

* fix issue pointed by gemini-code-assist

* fix bug the revision sort criteria was not right

* Added comments on existing task types (#387)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Adding new type definitions in contract, enum values of history data and resourcepaths

This commit includes contract related changes of the later task implementations.

* fix issue pointed by gemini-code-assist

* Add comments on existing tasks

* Adding the basic revision recorder for k8s audit log (#389)

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Adding manifest based history-modifier tasks and manifest utils

* Add the basic revision recording tasks for k8s audit logs

* fix issues pointed by gemini-code-assist

* Migrate pseudo subresource recorder in the previous k8s audit log parser tasks to the newly implemented k8s audit parser (#390)

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Adding manifest based history-modifier tasks and manifest utils

* Add the basic revision recording tasks for k8s audit logs

* fix issues pointed by gemini-code-assist

* Migrate pseudo recorders to the v2 k8s audit log parser tasks

---------

Signed-off-by: kyasbal <ikakeru@google.com>

* Adding new PodPhase recorder and register all defined tasks for k8s audit log parser package (#391)

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* Add podphase task and task registrations for the v2 audit parser

* fix issue pointed by gemini-code-assist

* Remove unused legacy parsers and migrate OSS log parsers to depend on the new audit log parsers (#392)

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Remove the unused legacy parsers and migrated OSS parsers to depend on the new parser

* fix issue pointed by gemini-code-assist

* Refactor inventory task base types (#394)

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Refactored relationship task and now it's named as InventoryTask

* Update pkg/core/inspection/taskbase/inventory_task.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: kyasbal <kyasbal1994@gmail.com>

* fix issue pointed by gemini-code-assist

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Adding node name inventory and refactored resource grouping logic (#395)

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Refactored relationship task and now it's named as InventoryTask

* Update pkg/core/inspection/taskbase/inventory_task.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: kyasbal <kyasbal1994@gmail.com>

* fix issue pointed by gemini-code-assist

* Adding nodename inventory task and refactored resource groups not to operate raw string

* fix issue pointed by gemini-code-assist

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Signed-off-by: kyasbal <ikakeru@google.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Improved container ID discovery tasks and implemented pod uid discovery tasks (#396)

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* fix issue pointed by gemini-code-assist

* Migrate containerID discovery tasks to use the inventory task and implemented resource UID inventory

* Improved containerd,kubelet and controlplane ID matchers to use inventory tasks

* Adding inventory tasks for IP leasing history and NEG names (#397)

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Adding grouping related tasks and tasks for gathering k8s audit logs from Cloud Logging  (#378)

* Added new fieldset related tasks and history modifiers for error audit logs

* fix issues pointed by gemini-code-assist

* Added new fieldset related tasks and history modifiers for error audit logs

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Adding k8s audit log parser tasks

* Added LogSorterTask that sorts logs before ingesting them to the manifest generator
* Added ChangeTargetGrouperTask that groups logs by the resource paths actually modified with the audit log
* Added NonSuccessLogGrouperTask that groups logs by resource paths for non succeeded audit logs

* fix issues pointed by gemini-code-assist

* Added several test asserter for changeset testing

* fix issues pointed by gemini-code-assist

* fix issues pointed by gemini-code-assist

* Implemented inventory for IP leases and NEG names

* fix issues pointed by gemini-code-assist

* bug: deletionGracePeriodSeconds=0 was always treated as completely removed even when finalizers exists (#398)

---------

Signed-off-by: kyasbal <ikakeru@google.com>
Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:parser enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants