feat(inspection): add progress reporting to manifest generator task#415
Conversation
Summary of ChangesHello @kyasbal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces progress reporting to the ManifestGeneratorTask, which is a valuable enhancement for user experience. The implementation correctly utilizes progressutil.NewProgressUpdator and an atomic counter for handling concurrent updates. The code is clean and aligns with existing patterns in the codebase. I have one suggestion to improve robustness by handling a potential edge case.
09e9516 to
f26f93c
Compare
This PR adds progress reporting to the
ManifestGeneratorTaskinpkg/task/inspection/commonlogk8sauditv2/impl/manifest_generator_task.go.It uses
progressutil.NewProgressUpdatorand an atomic counter to report the number of processed log groups in real-time, providing better visibility into the inspection progress in the UI. This implementation follows the pattern already established inManifestLogToTimelineMapper.Changes
ManifestGeneratorTaskto initialize aProgressUpdator.