Skip to content

feat(inspection): add progress reporting to manifest generator task#415

Merged
kyasbal merged 1 commit into
GoogleCloudPlatform:mainfrom
kyasbal:fix/report-manifest-generator-progress-report
Dec 15, 2025
Merged

feat(inspection): add progress reporting to manifest generator task#415
kyasbal merged 1 commit into
GoogleCloudPlatform:mainfrom
kyasbal:fix/report-manifest-generator-progress-report

Conversation

@kyasbal

@kyasbal kyasbal commented Dec 15, 2025

Copy link
Copy Markdown
Member

This PR adds progress reporting to the ManifestGeneratorTask in pkg/task/inspection/commonlogk8sauditv2/impl/manifest_generator_task.go.

It uses progressutil.NewProgressUpdator and an atomic counter to report the number of processed log groups in real-time, providing better visibility into the inspection progress in the UI. This implementation follows the pattern already established in ManifestLogToTimelineMapper.

Changes

  • Modified ManifestGeneratorTask to initialize a ProgressUpdator.
  • Added an atomic counter to track processed groups.
  • Updated the task to report progress percentage and a "current/total" message.

@kyasbal kyasbal added enhancement New feature or request backend:parser labels Dec 15, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kyasbal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the ManifestGeneratorTask by integrating real-time progress reporting. This change aims to provide users with better visibility into the ongoing inspection process within the UI, showing the number of log groups processed as the task executes.

Highlights

  • Progress Reporting: Implemented real-time progress reporting for the ManifestGeneratorTask to enhance UI visibility during inspection.
  • Implementation Details: Utilizes progressutil.NewProgressUpdator and an atomic.Int32 counter to track and report processed log groups.
  • Pattern Consistency: The new progress reporting mechanism follows the established pattern seen in ManifestLogToTimelineMapper.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kyasbal kyasbal marked this pull request as ready for review December 15, 2025 07:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces progress reporting to the ManifestGeneratorTask, which is a valuable enhancement for user experience. The implementation correctly utilizes progressutil.NewProgressUpdator and an atomic counter for handling concurrent updates. The code is clean and aligns with existing patterns in the codebase. I have one suggestion to improve robustness by handling a potential edge case.

Comment thread pkg/task/inspection/commonlogk8sauditv2/impl/manifest_generator_task.go Outdated
@kyasbal kyasbal force-pushed the fix/report-manifest-generator-progress-report branch from 09e9516 to f26f93c Compare December 15, 2025 07:27
@kyasbal kyasbal merged commit 70ad99d into GoogleCloudPlatform:main Dec 15, 2025
8 of 9 checks passed
@kyasbal kyasbal deleted the fix/report-manifest-generator-progress-report branch December 15, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend:parser enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants