Skip to content

Add renderer drawing revision rectangles#465

Merged
kyasbal merged 4 commits into
GoogleCloudPlatform:epic/timeline-v2from
kyasbal:epic/timeline-v2-add-revision-renderer
Jan 18, 2026
Merged

Add renderer drawing revision rectangles#465
kyasbal merged 4 commits into
GoogleCloudPlatform:epic/timeline-v2from
kyasbal:epic/timeline-v2-add-revision-renderer

Conversation

@kyasbal

@kyasbal kyasbal commented Jan 18, 2026

Copy link
Copy Markdown
Member

This PR adds renderers specific to draw diamond shaped dots for events.

This PR depends #463 and includes the changes introduced in #463. This would be merged after rebasing this on #463 once the parent review is done.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @kyasbal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades the timeline's rendering capabilities by introducing a comprehensive WebGL-based system for displaying and interacting with timeline revisions. The changes focus on improving rendering performance and enabling advanced visual effects through GPU acceleration, laying the groundwork for a more dynamic and responsive user interface.

Highlights

  • WebGL Utilities: Introduced a new WebGLUtil class to centralize common WebGL operations such as compiling and linking shaders, loading textures, and parsing BMFont configurations. This streamlines WebGL setup and resource management.
  • Timeline Hit Testing: Added TimelineHitTestSharedResource to implement efficient WebGL-based hit testing for timeline elements. This uses a framebuffer object (FBO) and a texture to render an index map, allowing quick identification of elements at specific screen coordinates.
  • Revision Renderer: Implemented TimelineRevisionsRenderer and TimelineRevisionsSharedResources to render timeline revisions using WebGL. This renderer leverages instanced rendering for performance, managing Vertex Array Objects (VAOs) and Vertex Buffer Objects (VBOs) for revision data and dynamic highlight states.
  • GLSL Shaders: New GLSL shaders (revision-v2.vertex.glsl, revision-v2.color-fragment.glsl, revision-v2.hittest-fragment.glsl, revision-v2.shared.glsl, v2.shared.glsl) were added to support the WebGL rendering of timeline revisions, including color rendering, hit testing, and shared uniform block definitions.
  • Shared Renderer Resources: The TimelineRendererSharedResource was updated to manage MSDF (Multi-channel Signed Distance Field) textures for numbers and icons, along with their BMFont configurations, and a shared Uniform Buffer Object (UBO) for global view state parameters.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kyasbal kyasbal changed the title Epic/timeline v2 add revision renderer Add renderer drawing revision rectangles Jan 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new WebGL-based renderer for timeline revisions, which is a significant feature. The implementation is comprehensive, covering WebGL utilities, shared resources, specific renderers for revisions, and the corresponding GLSL shaders. The code is well-structured, but I've found a critical issue with UBO layout padding that would cause rendering artifacts, along with several opportunities for performance improvements and increased code clarity. My review includes a fix for the critical bug, suggestions to parallelize asynchronous operations, optimizations for data lookups, and recommendations to replace magic numbers with named constants for better maintainability.

Comment thread web/src/app/timeline/components/canvas/glutil.ts
Comment thread web/src/app/timeline/components/canvas/glutil.ts
Comment thread web/src/app/timeline/components/canvas/hittest-shared-resource.ts
Comment thread web/src/app/timeline/components/canvas/timeline-shared-resource.ts
Comment thread web/src/assets/revision-v2.color-fragment.glsl
Comment thread web/src/assets/revision-v2.hittest-fragment.glsl
Comment thread web/src/assets/revision-v2.shared.glsl Outdated
@kyasbal kyasbal force-pushed the epic/timeline-v2-add-revision-renderer branch from b2c582c to 5c4de16 Compare January 18, 2026 08:36
@kyasbal kyasbal marked this pull request as ready for review January 18, 2026 08:39
@kyasbal kyasbal requested review from jyane and renamoo as code owners January 18, 2026 08:39
@kyasbal kyasbal merged commit 6fe0986 into GoogleCloudPlatform:epic/timeline-v2 Jan 18, 2026
8 of 9 checks passed
kyasbal added a commit that referenced this pull request Jan 22, 2026
* Add MSDF texture generation scripts (#445)

* Add MSDF texture generation scripts

To enable extensible and high quality font/icon rendering on WebGL2, this script precalculate MSDFs and bake it on textures.
These files are going to be used in the updated timeline v2 renderer.

* Removed font generation step from CI

The font atlas textures and its output JSON files are included in repository.
This design is because it won't be conflict a lot ,its easy to regenerate to merge. I'll integrate this step with CI later.
We don't need to run it on CI again.

* Applied fixes suggested by gemini

* Apply suggestions from code review

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: kyasbal <kyasbal1994@gmail.com>

* formatted icons.json

* fixed lint issue

* Removed icons.json because it's intermediate generated file

* Fix the lint issue and align the folder location with other generate task

* Move web/msdf to scripts/msdf-generator to align with the other generate scripts
* Ignored the json file from the root gitignore file for prettier to know the ignored files correctly

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Make msdf generator not to produce diffs (#448)

Ignored generated json files from the lint target and sort the icon list to keep it consistent.

* Add TimelineCornerIndicatorComponent and TimelineLegendComponent (#449)

* Add TimelineCornerIndicatorComponent and TimelineLegendComponent

* fix issues pointed by gemini-code-assist

* fix the issue pointed by gemini-code-assist

* Fixed the event legend message

And added the missing change to pass the storybook build

* Added angular-split used in the later commit (#451)

* Add TimelineIndexComponent (#450)

* Add TimelineIndexComponent

* fix compilation error

* Adding missing code from the commit

* fix stylesheet issues pointed by gemini-code-assist

* Fix typos in the comment

* Added base utilities for canvas (#453)

* Added base utilities for canvas

* Update web/src/app/timeline/components/gl/glcontextmanager.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: kyasbal <kyasbal1994@gmail.com>

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Adds algorithmic utility to implement timeline view (#452)

* Adds algorithmic utility to implement timeline view

* fixed issues pointed by gemini-code-assist

* Removed sRGB hex notation in the generated SCSS (#454)

* Removed sRGB hex notation in the generated SCSS

To show the same color with CSS and canvas(canvas2d or WebGL), removed the color setting directly specified with sRGB hex and hold them in floating point values instead.
KHI will use display-p3 color space rather than sRGB to use the wider color space.

* fix issues pointed by gemini-code-assist

* Add mising change expected to add in the commit

* Move folder from gl to canvas (#456)

the folder contained utility used for canvas 2d not WebGL. Renamed it not to confuse readers

* Add utility functions and types used for implementing the timeline header component (#457)

* Move folder from gl to canvas

the folder contained utility used for canvas 2d not WebGL. Renamed it not to confuse readers

* Added utility for drawing timeline header histogram

* fixed issues pointed by gemini-code-assist

* Added timeline header components (#458)

* Add timeline header component

* fix issue pointed by gemini-code-assist

* Fixed issues pointed by gemini-code-assist and fixed some styles

* fix typos

* Add WebGL related types used in revision renderer and event renderer (#463)

* Add WebGL related types used in revision renderer and event renderer

* fixed issues pointed by gemini-code-assist

* Add renderer for drawing event points (#464)

* Add WebGL related types used in revision renderer and event renderer

* fixed issues pointed by gemini-code-assist

* Add renderer for drawing event points

* fix suggested by gemini-code-assist

* Add renderer drawing revision rectangles (#465)

* Add WebGL related types used in revision renderer and event renderer

* fixed issues pointed by gemini-code-assist

* Add renderer drawing revision rectangles

* fix issue pointed by gemini-code-assist

* Add log filter status visualization feature (#466)

* Add TimelineChart component (#467)

* Adds timeline-chart Component

* Removed the obsoleted comment

* Add the hover component on timeline chart shown when user mouse is over (#468)

* Add the hover component on timeline chart shown when user mouse is over

* fix suggested by gemini-code-assist

* Added scroll interaction on the ruler & minor style improvement (#469)

* Added scroll interaction on the ruler & minor style improvement

* fix issue pointed by gemini-code-assist

* Add TimelineFrameComponent (#470)

* Add TimelineFrameComponent

This component is a virtually scrollable components embeds its children timeline related components.

* added missing change on the PR

* Fixed scroll caluclation bug

* Replace current timeline with the timeline component (#471)

* Add TimelineFrameComponent

This component is a virtually scrollable components embeds its children timeline related components.

* added missing change on the PR

* Fixed scroll caluclation bug

* Implemented TimelineSmartComponent and replace the current timeline component

This is the component only for injecting props from Services.

* Removed unused shaders

* Add a missing file

* Fix minor style problems (#472)

* Add TimelineFrameComponent

This component is a virtually scrollable components embeds its children timeline related components.

* Fixed scroll caluclation bug

* Fixed several minor style issues to prepare release

* fix z-index style issue and emphasized the time cursor

---------

Signed-off-by: kyasbal <kyasbal1994@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants