Skip to content

Change default listen host to 127.0.0.1 from localhost #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyasbal merged 1 commit into from
Jun 14, 2026
+4 −4
Merged

Change default listen host to 127.0.0.1 from localhost #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/parameters/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func (s *ServerParameters) PostProcess() error {
func (s *ServerParameters) Prepare() error {
s.ViewerMode = flag.Bool("viewer-mode", false, "Limits the KHI feature to query logs with the backend. When it is true, KHI is only serve the frontend to open KHI files.", "KHI_VIEWER_MODE")
s.Port = flag.Int("port", 8080, "The port number where KHI server listens.", "PORT")
s.Host = flag.String("host", "localhost", "The host address where KHI server serves.", "HOST")
s.Host = flag.String("host", "127.0.0.1", "The host address where KHI server serves.", "HOST")
s.BasePath = flag.String("base-path", "/", "The base address of API endpoints.", "KHI_BASE_PATH")
s.FrontendResourceBasePath = flag.String("frontend-resource-base-path", "", "Another base address only for frontend assets. If this value is not set, this uses `--base-path` value by default.", "KHI_FRONTEND_RESOURCE_PATH")
s.FrontendAssetFolder = flag.String("frontend-asset-folder", "", "The root folder of the assets used in frontend including index.html. If this value is not set, the assets embedded into the executable are used.", "KHI_FRONTEND_ASSET_FOLDER")
Expand Down
6 changes: 3 additions & 3 deletions pkg/parameters/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestServerParameters(t *testing.T) {
want: &ServerParameters{
ViewerMode: testutil.P(false),
Port: testutil.P(8080),
Host: testutil.P("localhost"),
Host: testutil.P("127.0.0.1"),
BasePath: testutil.P("/"),
FrontendResourceBasePath: testutil.P("/"),
FrontendAssetFolder: testutil.P(""),
Expand All @@ -54,7 +54,7 @@ func TestServerParameters(t *testing.T) {
want: &ServerParameters{
ViewerMode: testutil.P(false),
Port: testutil.P(8080),
Host: testutil.P("localhost"),
Host: testutil.P("127.0.0.1"),
BasePath: testutil.P("/foo/bar/"),
FrontendResourceBasePath: testutil.P("/foo/bar/"),
FrontendAssetFolder: testutil.P(""),
Expand All @@ -70,7 +70,7 @@ func TestServerParameters(t *testing.T) {
want: &ServerParameters{
ViewerMode: testutil.P(false),
Port: testutil.P(8080),
Host: testutil.P("localhost"),
Host: testutil.P("127.0.0.1"),
BasePath: testutil.P("/foo/bar/"),
FrontendResourceBasePath: testutil.P("/foo/"),
FrontendAssetFolder: testutil.P(""),
Expand Down
Loading