-
Notifications
You must be signed in to change notification settings - Fork 351
Add EntryLinks support #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eeshadutta1408
wants to merge
14
commits into
GoogleCloudPlatform:main
Choose a base branch
from
eeshadutta1408:entry-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
aa2e43e
Initial implementation of EntryLinks support
eeshadutta1408 7ee7fda
Support different types of EntryLinks
eeshadutta1408 ee81b78
EntryLinks pull
eeshadutta1408 0be4b2b
Design
eeshadutta1408 222c3b9
Fix for empty names
eeshadutta1408 fda8598
Resolve glossary and terms in EntryLinks
eeshadutta1408 4fd1c6f
docs: document specific handling of definition and schema-join entry …
eeshadutta1408 88be703
feat: implement symmetrical reference resolution and matching for sch…
eeshadutta1408 9f6abcf
chore: remove dry-run CLI options and synchronization logic
eeshadutta1408 afc4961
Merge upstream/main into entry-links
eeshadutta1408 cd24561
Merge remote-tracking branch 'upstream/main' into entry-links
eeshadutta1408 7b27a2a
Resolve PR comments
eeshadutta1408 26191cf
fix(sync): resolve EntryLink deletion, project number mismatches, and…
eeshadutta1408 b1827e0
test(sync): add EntryLinks push scenario and improve mock layout inde…
eeshadutta1408 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| build/ | ||
| dist/ | ||
| node_modules/ | ||
| catalog.yaml | ||
| catalog/ | ||
| tests/scenarios/ |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to page through the list of entry links to retrieve them all similar to list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should. Updated
lookupEntryLinksto use ado-whileloop that pages through all available entry links usingnextPageToken (similar to the logic inlistEntryLinks).