fix: correct enrichment doc paths, CLI name, and broken link#121
Open
mftnakrsu wants to merge 1 commit into
Open
fix: correct enrichment doc paths, CLI name, and broken link#121mftnakrsu wants to merge 1 commit into
mftnakrsu wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
Fix user-facing references in the enrichment docs and runtime messages that point to names/paths that don't exist: kcenrich -> kcagent and demo-dataset -> demo_ecommerce in toolbox/enrichment/README.md; broken ../docs/sharepoint-setup.md link in agents/enrichment/README.md; and toolbox/enrichment/... -> agents/enrichment/... setup-script paths in sharepoint-setup.md and the agent_runner.py / sharepoint_tools.py runtime messages. Docs/help-text only; no behavior change.
26dab61 to
64ef7cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes several user-facing references in the enrichment docs and runtime messages that point to names/paths which don't exist, so anyone following the docs hits a wrong command or a missing file.
Changes
toolbox/enrichment/README.mdkcenrich→kcagent. The binary iskcagent(src/agent/main.ts→cac.cac('kcagent'),package.jsonbin.kcagent) and the enrich command is invoked askcagent enrich(already used later in the same README, line 26).kcenrichdoes not exist anywhere in the package.bq rm -r ${DEMO_CLOUD_PROJECT}:demo-dataset→:demo_ecommerce. The demo createsdemo_ecommerce;demo-datasetis never created, so the documented cleanup would not remove the demo dataset.agents/enrichment/README.md[docs/sharepoint-setup.md](../docs/sharepoint-setup.md)→(docs/sharepoint-setup.md). The../docs/target resolves toagents/docs/sharepoint-setup.md, which doesn't exist; the file lives atagents/enrichment/docs/sharepoint-setup.md. This matches the correct link already used earlier in the same file (line 75).agents/enrichment/docs/sharepoint-setup.mdpython3 toolbox/enrichment/...→python3 agents/enrichment/.... The setup script and agent runner live underagents/enrichment/(scripts/setup_sharepoint.py,src/agent_runner.py);toolbox/enrichment/is the unrelated TypeScript package and has no such files.agents/enrichment/src/agent_runner.py,agents/enrichment/src/tools/sharepoint_tools.pytoolbox/enrichment/scripts/setup_sharepoint.py; corrected toagents/enrichment/scripts/setup_sharepoint.pyso the printed guidance matches the real path.Notes
Documentation / help-text only — no behavior change. The two Python edits change only string literals in user-facing messages (verified with
py_compile).🤖 Generated with Claude Code