Skip to content

fix: correct enrichment doc paths, CLI name, and broken link#121

Open
mftnakrsu wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
mftnakrsu:docs/fix-enrichment-doc-references
Open

fix: correct enrichment doc paths, CLI name, and broken link#121
mftnakrsu wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
mftnakrsu:docs/fix-enrichment-doc-references

Conversation

@mftnakrsu

Copy link
Copy Markdown

What

Fixes several user-facing references in the enrichment docs and runtime messages that point to names/paths which don't exist, so anyone following the docs hits a wrong command or a missing file.

Changes

  • toolbox/enrichment/README.md
    • CLI name: kcenrichkcagent. The binary is kcagent (src/agent/main.tscac.cac('kcagent'), package.json bin.kcagent) and the enrich command is invoked as kcagent enrich (already used later in the same README, line 26). kcenrich does not exist anywhere in the package.
    • Demo cleanup: bq rm -r ${DEMO_CLOUD_PROJECT}:demo-dataset:demo_ecommerce. The demo creates demo_ecommerce; demo-dataset is never created, so the documented cleanup would not remove the demo dataset.
  • agents/enrichment/README.md
    • Broken relative link [docs/sharepoint-setup.md](../docs/sharepoint-setup.md)(docs/sharepoint-setup.md). The ../docs/ target resolves to agents/docs/sharepoint-setup.md, which doesn't exist; the file lives at agents/enrichment/docs/sharepoint-setup.md. This matches the correct link already used earlier in the same file (line 75).
  • agents/enrichment/docs/sharepoint-setup.md
    • python3 toolbox/enrichment/...python3 agents/enrichment/.... The setup script and agent runner live under agents/enrichment/ (scripts/setup_sharepoint.py, src/agent_runner.py); toolbox/enrichment/ is the unrelated TypeScript package and has no such files.
  • agents/enrichment/src/agent_runner.py, agents/enrichment/src/tools/sharepoint_tools.py
    • The runtime "no Microsoft credentials" messages instruct users to run toolbox/enrichment/scripts/setup_sharepoint.py; corrected to agents/enrichment/scripts/setup_sharepoint.py so the printed guidance matches the real path.

Notes

Documentation / help-text only — no behavior change. The two Python edits change only string literals in user-facing messages (verified with py_compile).

🤖 Generated with Claude Code

@google-cla

google-cla Bot commented Jun 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mftnakrsu

Copy link
Copy Markdown
Author

@googlebot I signed it!

@mftnakrsu mftnakrsu closed this Jun 20, 2026
@mftnakrsu mftnakrsu reopened this Jun 20, 2026
Fix user-facing references in the enrichment docs and runtime messages that point to names/paths that don't exist: kcenrich -> kcagent and demo-dataset -> demo_ecommerce in toolbox/enrichment/README.md; broken ../docs/sharepoint-setup.md link in agents/enrichment/README.md; and toolbox/enrichment/... -> agents/enrichment/... setup-script paths in sharepoint-setup.md and the agent_runner.py / sharepoint_tools.py runtime messages. Docs/help-text only; no behavior change.
@mftnakrsu mftnakrsu force-pushed the docs/fix-enrichment-doc-references branch from 26dab61 to 64ef7cf Compare June 20, 2026 18:36
@mftnakrsu mftnakrsu marked this pull request as ready for review June 20, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant