Skip to content

Add unit tests for config/package_resource.go PART 3 - #1008

Merged
google-oss-prow[bot] merged 6 commits into
GoogleCloudPlatform:masterfrom
bromivipo:package_resource3
Aug 12, 2026
Merged

Add unit tests for config/package_resource.go PART 3#1008
google-oss-prow[bot] merged 6 commits into
GoogleCloudPlatform:masterfrom
bromivipo:package_resource3

Conversation

@bromivipo

@bromivipo bromivipo commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Refactors CheckState tests and adds additional test coverage for checkState and Cleanup

@google-oss-prow

Copy link
Copy Markdown

Hi @bromivipo. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bromivipo
bromivipo force-pushed the package_resource3 branch from 99860d8 to 79de396 Compare July 28, 2026 08:51
@bromivipo
bromivipo marked this pull request as ready for review July 28, 2026 08:53
@google-oss-prow
google-oss-prow Bot requested a review from savija-tv July 28, 2026 08:53
@burov

burov commented Jul 28, 2026

Copy link
Copy Markdown
Member

/gcbrun

@burov

burov commented Jul 28, 2026

Copy link
Copy Markdown
Member

/gcbrun

@burov

burov commented Aug 11, 2026

Copy link
Copy Markdown
Member

/gcbrun

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bromivipo, burov, petercieslak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
google-oss-prow Bot merged commit 390fd0f into GoogleCloudPlatform:master Aug 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants