Add scalibr flow for windows - #1037
Conversation
|
Hi @bromivipo. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| packages.Chocolatey = append(packages.Chocolatey, pkgInfoFromGenericExtractorPackage(pkg, purl.TypeChocolatey)) | ||
| } else if _, ok := pkg.Metadata.(*scalibrwinget.Metadata); ok { | ||
| packages.WinGet = append(packages.WinGet, pkgInfoFromGenericExtractorPackage(pkg, purl.TypeWinget)) | ||
| } else if pkg.PURLType == purl.TypeGooget || (pkg.PURL() != nil && pkg.PURL().Type == purl.TypeGooget) { |
There was a problem hiding this comment.
As I understand it, Scalibr doesn't have a specific metadata type for GooGet packages, so we can't reuse the standard metadata conversion logic. Is this alternative approach ok?
| if projectSettings.ExtendedInventoryCollectionInterval != nil { | ||
| if val, err := projectSettings.ExtendedInventoryCollectionInterval.Int64(); err == nil { | ||
| c.extendedInventoryCollectionInterval = int(val) | ||
| } |
There was a problem hiding this comment.
I suppose we should raise an error if err != nil. Consider to create parseInt64
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bromivipo, iliatsuprik The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
2 participants
This PR integrates Scalibr scanning flow for Windows and adds OS-specific package extractors.
Changes Included: