fix(hub): implement proper agent resume and restart dispatch#11
Closed
kweinmeister wants to merge 2 commits into
Closed
fix(hub): implement proper agent resume and restart dispatch#11kweinmeister wants to merge 2 commits into
kweinmeister wants to merge 2 commits into
Conversation
This resolves a TODO where the Hub was unable to properly resume or restart a stopped agent via a co-located runtime broker dispatcher. It abstracts the StartOptions construction and utilizes the agent manager's Start method with the Resume flag.
This refactor addresses three key improvements in cmd/server.go: 1. DRY: Extracted identical grove path resolution logic into a resolveGrovePath() helper. 2. Clean Architecture: Removed side-effects from buildStartOptions() by moving hubAgent mutation (labels) into the calling dispatch methods. 3. Consistency: Applied the grove ID label consistently across Create, Start, and Restart operations.
Member
|
merged in 30a1b74 after local rebase |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a TODO where the Hub was unable to properly resume or restart a stopped agent via a co-located runtime broker dispatcher. It abstracts the StartOptions construction and utilizes the agent manager's Start method with the Resume flag. Includes new tests in cmd/server_dispatcher_test.go.