Skip to content

fix(image-build): use default builder for local docker builds #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptone merged 2 commits into from
Jun 18, 2026
+14 −4
Merged

fix(image-build): use default builder for local docker builds #442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11119b5
fix(image-build): use default builder for local docker builds
subspacecoms Jun 18, 2026
2ebea3c
fix(image-build): use BUILDX_BUILDER env var to avoid mutating global…
ptone Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions image-build/scripts/builders/local-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,27 @@ builder_check() {
}

builder_prepare() {
if [[ "${PUSH:-false}" != "true" ]]; then
if [[ "${DRY_RUN:-false}" == "true" ]]; then
echo "[dry-run] export BUILDX_BUILDER=default"
return 0
fi
echo "Using default docker builder for local build..."
export BUILDX_BUILDER="default"
return 0
fi
Comment on lines +37 to +45

@gemini-code-assist gemini-code-assist Bot Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using docker buildx use <builder> mutates the user's global Docker CLI configuration (specifically ~/.docker/buildx/current), which permanently changes their active builder even after this script finishes executing. This can be disruptive to developers running the script locally.

Instead, you can use the BUILDX_BUILDER environment variable. Setting export BUILDX_BUILDER=default achieves the same result but is scoped only to the current script execution, leaving the user's global configuration untouched.

Note: You should also apply this pattern to the PUSH == true branch (lines 52-57) by using export BUILDX_BUILDER="${BUILDX_INSTANCE}" and removing the --use flag from docker buildx create.

Suggested change
if [[ "${PUSH:-false}" != "true" ]]; then
if [[ "${DRY_RUN:-false}" == "true" ]]; then
echo "[dry-run] docker buildx use default"
return 0
fi
echo "Using default docker builder for local build..."
docker buildx use default
return 0
fi
if [[ "${PUSH:-false}" != "true" ]]; then
if [[ "${DRY_RUN:-false}" == "true" ]]; then
echo "[dry-run] export BUILDX_BUILDER=default"
return 0
fi
echo "Using default docker builder for local build..."
export BUILDX_BUILDER="default"
return 0
fi


if [[ "${DRY_RUN:-false}" == "true" ]]; then
echo "[dry-run] docker buildx create --name ${BUILDX_INSTANCE} --use # if missing"
echo "[dry-run] docker buildx create --name ${BUILDX_INSTANCE} # if missing"
echo "[dry-run] export BUILDX_BUILDER=${BUILDX_INSTANCE}"
echo "[dry-run] docker buildx inspect --bootstrap"
return 0
fi
if ! docker buildx inspect "${BUILDX_INSTANCE}" >/dev/null 2>&1; then
echo "Creating buildx builder '${BUILDX_INSTANCE}'..."
docker buildx create --name "${BUILDX_INSTANCE}" --use
else
docker buildx use "${BUILDX_INSTANCE}"
docker buildx create --name "${BUILDX_INSTANCE}"
fi
export BUILDX_BUILDER="${BUILDX_INSTANCE}"
docker buildx inspect --bootstrap >/dev/null
}

Expand Down