Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1324 +/- ##
==========================================
+ Coverage 51.15% 51.19% +0.03%
==========================================
Files 202 202
Lines 22639 22796 +157
Branches 552 552
==========================================
+ Hits 11582 11671 +89
- Misses 10375 10437 +62
- Partials 682 688 +6
🚀 New features to boost your workflow:
|
f4084b5 to
169838d
Compare
pratickchokhani
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a 5,000-table integration test for MySQL direct connect and introduces a
BatchedInfoSchemainterface to allow bulk metadata fetching, improving performance for large schemas.Changes
BatchedInfoSchema: New interface ininfoschema.gofor bulk fetching of columns, constraints, FKs, and indexes.GenerateSrcSchemato process tables in parallel batches.TestIntegration_MYSQL_DirectConnect_5000Tablesand 5,000 table SQL dump.TestGetConstraints_CheckConstraintsTableAbsent: Updated the test to expect success when theCHECK_CONSTRAINTStable is missing. Now validates the fallback logic that uses a simpler query to fetchTABLE_CONSTRAINTSwhen the check constraints table is unavailable. Previously, the test was incorrectly asserting failure due to an incomplete mock setup for the fallback query.ExpressionIdin Source Schema Assertions: Modified the test helperassertSrcColDefininternal/test_util.goto ignoreExpressionIdfor both expected and actual columns. This avoids test brittleness caused by non-deterministic ID generation order during parallel batch processing.Batch Size Experiments (5k Tables)
Conclusion: Larger batch sizes significantly reduce schema processing time. The PR currently defaults to 50.