Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
=======================================
Coverage 47.52% 47.52%
=======================================
Files 234 234
Lines 27098 27098
Branches 602 602
=======================================
Hits 12879 12879
Misses 13473 13473
Partials 746 746
🚀 New features to boost your workflow:
|
rohitwali
reviewed
Apr 29, 2026
rohitwali
left a comment
Contributor
There was a problem hiding this comment.
thanks for the changes Sandeep. Can you add some context on the changes and any broader intent behind it?
Contributor
Author
@rohitwali i was trying to add a 5k tables integration test for schema migration and it turned out that the max number of tables for a db in spanner emulator is 2560. Given that spanner omni was recently released and that might be more close to cloud spanner in its features / behaviour i was doing a POC if we can replace emulator with omni in our tests. |
rohitwali
approved these changes
May 4, 2026
aad7466 to
2dd2af2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates integration tests from the legacy Cloud Spanner Emulator to Spanner Omni.
Changes
.github/workflows/integration-tests-against-emulator.yamltointegration-tests-against-omni.yamland updated it to use the Spanner Omni docker image (us-docker.pkg.dev/spanner-omni/images/spanner-omni:2026.r1-beta).defaultto align with Spanner Omni's automatic default setup.README.md,docs/install.md, anddocs/testing.mdto provide instructions for Spanner Omni instead of the emulator.onlyRunForEmulatorTesttoonlyRunForOmniTestacross all integration test files.TestUpdateDDLForeignKeysfrom 1 to 5. (this was not possible in emulator)