Skip to content

omni migration#1325

Merged
sm745052 merged 13 commits into
masterfrom
omni
May 7, 2026
Merged

omni migration#1325
sm745052 merged 13 commits into
masterfrom
omni

Conversation

@sm745052

@sm745052 sm745052 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrates integration tests from the legacy Cloud Spanner Emulator to Spanner Omni.

Changes

  • CI/CD: Renamed .github/workflows/integration-tests-against-emulator.yaml to integration-tests-against-omni.yaml and updated it to use the Spanner Omni docker image (us-docker.pkg.dev/spanner-omni/images/spanner-omni:2026.r1-beta).
  • Configuration: Changed default project and instance IDs to default to align with Spanner Omni's automatic default setup.
  • Documentation: Updated README.md, docs/install.md, and docs/testing.md to provide instructions for Spanner Omni instead of the emulator.
  • Tests:
    • Renamed helper function onlyRunForEmulatorTest to onlyRunForOmniTest across all integration test files.
    • Updated code comments referencing the emulator to reference Spanner Omni.
    • Increased concurrent workers in TestUpdateDDLForeignKeys from 1 to 5. (this was not possible in emulator)

@sm745052 sm745052 requested a review from a team as a code owner April 29, 2026 10:42
@sm745052 sm745052 requested review from darshan-sj and rohitwali and removed request for a team April 29, 2026 10:42
@sm745052 sm745052 marked this pull request as draft April 29, 2026 10:42
@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.52%. Comparing base (ff062c6) to head (e82aa88).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   47.52%   47.52%           
=======================================
  Files         234      234           
  Lines       27098    27098           
  Branches      602      602           
=======================================
  Hits        12879    12879           
  Misses      13473    13473           
  Partials      746      746           
Components Coverage Δ
backend-apis 42.98% <ø> (ø)
backend-library 51.87% <ø> (ø)
cli 24.10% <ø> (ø)
frontend 38.56% <ø> (ø)
Files with missing lines Coverage Δ
cmd/import.go 86.93% <ø> (ø)
common/utils/utils.go 2.08% <ø> (ø)
sources/spanner/infoschema.go 5.20% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rohitwali rohitwali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes Sandeep. Can you add some context on the changes and any broader intent behind it?

@sm745052

sm745052 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

thanks for the changes Sandeep. Can you add some context on the changes and any broader intent behind it?

@rohitwali i was trying to add a 5k tables integration test for schema migration and it turned out that the max number of tables for a db in spanner emulator is 2560.

Given that spanner omni was recently released and that might be more close to cloud spanner in its features / behaviour i was doing a POC if we can replace emulator with omni in our tests.

Comment thread .github/workflows/integration-tests-against-emulator.yaml
@pull-request-size pull-request-size Bot added size/L and removed size/M labels May 7, 2026
@sm745052 sm745052 marked this pull request as ready for review May 7, 2026 07:46
@sm745052 sm745052 force-pushed the omni branch 3 times, most recently from aad7466 to 2dd2af2 Compare May 7, 2026 08:05
@sm745052 sm745052 merged commit dc3e2cb into master May 7, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants