Skip to content

Parse timestamp attr from testcase in junit xml. - #1328

Merged
google-oss-prow[bot] merged 1 commit into
GoogleCloudPlatform:mainfrom
n-rook:nrook/add-testcase-timestamp
Aug 10, 2026
Merged

Parse timestamp attr from testcase in junit xml.#1328
google-oss-prow[bot] merged 1 commit into
GoogleCloudPlatform:mainfrom
n-rook:nrook/add-testcase-timestamp

Conversation

@n-rook

@n-rook n-rook commented Aug 10, 2026

Copy link
Copy Markdown

timestamp is just read as a string, as is already the case for the timestamp field on testsuite elements. A lot of test runners don't set this attribute, but some do, such as Terraform:

https://developer.hashicorp.com/terraform/cli/commands/test

The goal here is to allow other software that uses the testgrid xml-parsing library to read this attribute. I do not anticipate this attribute being used by testgrid itself, since I do not think testgrid really operates on this small of a scale. Although of course it could be used someday.

timestamp is just read as a string, as is already the case
for the timestamp field on testsuite elements. A lot of test runners
don't set this attribute, but some do, such as Terraform:

https://developer.hashicorp.com/terraform/cli/commands/test
@google-oss-prow

Copy link
Copy Markdown
Contributor

Hi @n-rook. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, michelle192837, n-rook

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [chases2,michelle192837]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
google-oss-prow Bot merged commit 639851f into GoogleCloudPlatform:main Aug 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants