removed unused hamming distance functions - #1213
Merged
ryneeverett merged 2 commits intoMay 28, 2026
Merged
Conversation
ryneeverett
reviewed
May 22, 2026
Collaborator
Agreed. I'm supportive of intentionally removing that behavior, I just wanted to make sure we didn't do so on accident. |
Lotram
force-pushed
the
simplify-annotation-merge
branch
from
May 25, 2026 15:47
9fde844 to
8a0d1a0
Compare
ryneeverett
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simplified the code related to merging tags and annotations.
In particular, the hamming distance code was unused.
While I think it makes sense to keep the "normalize_annotation" function (even though I don't see why the annotation would slightly change between calls to services), I'm not sure the "compare only length of shortest string" behavior brings anything useful (but I kept it for now).