Skip to content

Simplify get_tags_from_labels - #1216

Merged
ryneeverett merged 1 commit into
GothenburgBitFactory:developfrom
Lotram:simplify-get-tags-from-labels
Jun 8, 2026
Merged

Simplify get_tags_from_labels#1216
ryneeverett merged 1 commit into
GothenburgBitFactory:developfrom
Lotram:simplify-get-tags-from-labels

Conversation

@Lotram

@Lotram Lotram commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

A few services were not using the default parameter names for the get_tags_from_labels (pagure and youtrack)

I changed the config param names for those service, while allowing multiple aliases, to ensure backward compatibility.

This allows for a much simpler get_tags_from_labels, only parameters being the labels and the config.
We could even consider moving this function outside the Service class, since it does not depend on the Service subclass (or this could be a ServiceConfig method instead).

@Lotram Lotram changed the title Simplify get tags from labels Simplify get_tags_from_labels Jun 3, 2026
@Lotram
Lotram force-pushed the simplify-get-tags-from-labels branch from 4547367 to 9473378 Compare June 4, 2026 10:42

@ryneeverett ryneeverett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I don't see much point in adding deprecation notices to the documentation. If somebody isn't using the deprecated options then they don't need to know about them. If they are using them then they'll get the exact same information from the log warnings.
  • We should add an entry to the api.rst changelog mentioning the addition of render_tags_from_labels. (I'm inclined to think we shouldn't mention deprecated parameters in that changelog. Since deprecations don't necessarily require a version bump, there wouldn't necessarily be any place to log them so we shouldn't set that precedent.)

Comment thread bugwarrior/services/__init__.py Outdated
use the same parameter names in every service
@Lotram
Lotram force-pushed the simplify-get-tags-from-labels branch from 9473378 to ad10751 Compare June 8, 2026 09:22
@ryneeverett
ryneeverett merged commit a16fdf2 into GothenburgBitFactory:develop Jun 8, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants