Simplify get_tags_from_labels - #1216
Merged
ryneeverett merged 1 commit intoJun 8, 2026
Merged
Conversation
Lotram
force-pushed
the
simplify-get-tags-from-labels
branch
from
June 4, 2026 10:42
4547367 to
9473378
Compare
ryneeverett
reviewed
Jun 6, 2026
ryneeverett
left a comment
Collaborator
There was a problem hiding this comment.
- I don't see much point in adding deprecation notices to the documentation. If somebody isn't using the deprecated options then they don't need to know about them. If they are using them then they'll get the exact same information from the log warnings.
- We should add an entry to the api.rst changelog mentioning the addition of
render_tags_from_labels. (I'm inclined to think we shouldn't mention deprecated parameters in that changelog. Since deprecations don't necessarily require a version bump, there wouldn't necessarily be any place to log them so we shouldn't set that precedent.)
use the same parameter names in every service
Lotram
force-pushed
the
simplify-get-tags-from-labels
branch
from
June 8, 2026 09:22
9473378 to
ad10751
Compare
ryneeverett
approved these changes
Jun 8, 2026
ryneeverett
merged commit Jun 8, 2026
a16fdf2
into
GothenburgBitFactory:develop
7 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few services were not using the default parameter names for the
get_tags_from_labels(pagure and youtrack)I changed the config param names for those service, while allowing multiple aliases, to ensure backward compatibility.
This allows for a much simpler
get_tags_from_labels, only parameters being the labels and the config.We could even consider moving this function outside the
Serviceclass, since it does not depend on the Service subclass (or this could be aServiceConfigmethod instead).