Add a notification panel section to the workspace page - #4224
Open
twjeffery wants to merge 1 commit into
Open
Conversation
|
Preview links
Built from commit fe33a87. Previews are removed automatically when this PR closes. |
twjeffery
marked this pull request as ready for review
August 13, 2026 07:01
ArakTaiRoth
reviewed
Aug 13, 2026
|
|
||
| Keep each notification to what happened, which record, and when, so the panel can be scanned without opening anything. Use the urgent priority to weight what matters most in your service's context. The panel offers a "View all" link, so plan for a full notifications page to sit behind it. | ||
|
|
||
| <img |
Collaborator
There was a problem hiding this comment.
I don't know if this image is up to date? It still shows what I think is a problem that Vanessa fixed recently, that is the Notification Panel is lined up completely with the bottom of the viewport, rather than having some padding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4223
Before (the change)
The workspace product type page documents four interaction patterns: data views, sidebar navigation, sticky action bar, and push drawer. There is nothing for the notification panel, even though it shipped, has its own component page, and opens from the work side menu that this same page documents as the primary navigation.
The thumbnail for it has been sitting in the repo since 2026-04-30 and is referenced nowhere, so the section looks like it was intended and never written.
After (the change)
A Notifications section under Interaction patterns, in the same shape and weight as the ones beside it: an opening paragraph, a short list, a couple of closing lines, and one image.
The thumbnail is recaptured rather than reused. The existing image showed notification items with text badges ("New", "Urgent"), which the shipped component does not render.
WorkSideNotificationItemrenders its badge as icon only, derived from the item's type:There is no
contentattribute, so shipping the old image would have documented an interface the component cannot produce. The new capture is taken from the template at 1440x900 with a 2x device pixel ratio, giving 2880x1800, which matches the other workspace thumbnails.No code changes.
Note for the reviewer
This touches the same file as #4222, which is open for review now. The two changes are about 165 lines apart in that file, so they merge cleanly in either order. Happy to rebase whichever one lands second.
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test