fix(#2981): Updated read only styling for Input and DatePicker - #4229
Open
ArakTaiRoth wants to merge 1 commit into
Open
fix(#2981): Updated read only styling for Input and DatePicker#4229ArakTaiRoth wants to merge 1 commit into
ArakTaiRoth wants to merge 1 commit into
Conversation
|
Preview links
Built from commit 0f50ad9. Previews are removed automatically when this PR closes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
Input read-only state was incorrectly providing a border on hover and on focus. This was happening because it was assumed it had to happen to allow Date Picker to continue to have a border (it uses input read-only state to function).
After (the change)
The CSS targeting
box-shadowfor Input's read-only stated was corrected, which wasn't written correctly first off and incorrectly didn't target hover and focus modes. The CSS for Date Picker was expanded to target focus and hover modes specifically instead.Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
You can test using the docs PRs for both Date Picker and Input, there's a Read Only state for Input in there.