Fix three crash bugs: compactor NameError, ShotBriefDescription.__str__, novel2movie __call__#56
Open
fviolette26 wants to merge 1 commit into
Open
Fix three crash bugs: compactor NameError, ShotBriefDescription.__str__, novel2movie __call__#56fviolette26 wants to merge 1 commit into
fviolette26 wants to merge 1 commit into
Conversation
…__, novel2movie __call__ - context_compactor._message_preview referenced the undefined name tool_calls instead of the string "tool_calls", raising NameError for any message carrying tool calls. - ShotBriefDescription.__str__ read sound_effect/speaker/emotion/line, fields long since commented out of the model, so str() raised AttributeError; it now renders the live audio_desc field. - Novel2MoviePipeline.__call__ was a stale duplicate of the planning and rendering helpers: it re-gathered already-awaited coroutines from its retrieval step (RuntimeError on every fresh run) and called script2video with a nonexistent character_registry kwarg and no user_requirement. It now delegates to plan_text_artifacts and render_video_artifacts, which contain the corrected logic. Adds regression tests for all three. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three crash bugs, each verified with a regression test (all written test-first):
agent_runtime/context_compactor.py—_message_previewreferenced the undefined bare nametool_callsinstead of the string"tool_calls", raisingNameErrorfor any message carrying tool calls.interfaces/shot_description.py—ShotBriefDescription.__str__readsound_effect/speaker/emotion/line, fields that are commented out of the model, so anystr()of a shot raisedAttributeError. It now renders the liveaudio_descfield.pipelines/novel2movie_pipeline.py—__call__was a stale duplicate ofplan_text_artifacts/render_video_artifacts: it re-gathered already-awaited coroutines from its retrieval step (RuntimeError: cannot reuse already awaited coroutineon every fresh run), called script2video with a nonexistentcharacter_registrykwarg and no requireduser_requirement, and usedcharacter.idxon a model that only definesindex. It now delegates to the two maintained helpers, which contain the corrected logic (−514 lines).Test plan
uv run --with pytest python -m pytest tests/— 105 passed (102 existing + 3 new intests/test_crash_regressions.py).🤖 Generated with Claude Code