Skip to content

AB#64926 fix svg styles leaking outside of svg elements #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avicarie merged 2 commits into from
Sep 4, 2025
Merged

AB#64926 fix svg styles leaking outside of svg elements #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19ecbd1
AB#64926 fix svg styles leaking outside of svg elements
avicarie Sep 4, 2025
ccbdabe
Update dev.yml
avicarie Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v1
uses: actions/checkout@v4
- name: Cypress run
uses: cypress-io/github-action@v2
uses: cypress-io/github-action@v6
with:
config-file: /cypress.dev.json
env:
Expand All @@ -22,13 +22,13 @@ jobs:
CYPRESS_TESTING_HSLID_USERNAME: ${{ secrets.CYPRESS_TESTING_HSLID_USERNAME }}
CYPRESS_TESTING_HSLID_PASSWORD: ${{ secrets.CYPRESS_TESTING_HSLID_PASSWORD }}
- name: Upload screenshot artifacts
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-screenshots
path: cypress/screenshots
- name: Upload video artifacts
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
if: always()
with:
name: cypress-videos
Expand Down
8 changes: 7 additions & 1 deletion src/components/TemplateImage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,13 @@ class TemplateImage extends Component {

return (
<UploadDrop className={className} onDrop={this.onDrop} name="footer_image" disablePreview>
<Item dangerouslySetInnerHTML={{ __html: svg }} />
<Item>
<iframe
title="SVG"
srcDoc={`<html><body>${svg}</body></html>`}
style={{ border: 'none', width: '100%', height: '100%' }}
/>
</Item>
</UploadDrop>
);
}
Expand Down
Loading