Skip to content

Make deterministic spawn bugfix toggleable #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
V10lator wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Make deterministic spawn bugfix toggleable #479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74ead67
Make deterministic spawn bugfix toggleable
V10lator Jul 18, 2025
6762257
Make option false by default
V10lator Jul 18, 2025
9d05ebc
Reset podium PRNG and make it replaceable with cstd rand(), too
V10lator Jul 19, 2025
6167675
Rename option
V10lator Jul 31, 2025
2e6a5c4
Revert "Make option false by default"
V10lator Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,6 +550,10 @@ void init_segment_racing(void) {
dma_copy((u8*) SEG_RACING, (u8*) SEG_RACING_ROM_START, SEG_RACING_ROM_SIZE);
osInvalICache((void*) SEG_RACING, SEG_RACING_SIZE);
osInvalDCache((void*) SEG_RACING, SEG_RACING_SIZE);
#else
if (CVarGetInteger("gBugfixDeterministicSpawn", true) == false) {
Comment thread
V10lator marked this conversation as resolved.
Outdated
gRandomSeed16 = 0;
}
#endif
}

Expand Down Expand Up @@ -1222,7 +1226,7 @@ void update_gamestate(void) {
* @bug Reloading this segment makes random_u16() deterministic for player spawn order.
* In laymens terms, random_u16() outputs the same value every time.
*/
// init_segment_racing();
init_segment_racing();
setup_race();
break;
case ENDING:
Expand All @@ -1232,7 +1236,7 @@ void update_gamestate(void) {
break;
case CREDITS_SEQUENCE:
gCurrentlyLoadedCourseId = COURSE_NULL;
// init_segment_racing();
init_segment_racing();
init_segment_ending_sequences();
load_credits();
break;
Expand Down
6 changes: 6 additions & 0 deletions src/port/ui/PortMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,12 @@ void PortMenu::AddEnhancements() {
})
.Options(UIWidgets::CheckboxOptions({ { .tooltip = "Edit the universe!" } }));
#endif

path = { "Enhancements", "Bugfixes", SECTION_COLUMN_1 };
AddSidebarEntry("Enhancements", "Bugfixes", 3);
AddWidget(path, "Deterministic Spawn", WIDGET_CVAR_CHECKBOX)
.CVar("gBugfixDeterministicSpawn")
.Options(CheckboxOptions().Tooltip("This fixes players always spawning at the same position when starting a new cup").DefaultValue(true));
}

#ifdef __SWITCH__
Expand Down
Loading