Add CoreAudio to audio backend combobox map for macOS#686
Open
mkoterski wants to merge 1 commit intoHarbourMasters:mainfrom
Open
Add CoreAudio to audio backend combobox map for macOS#686mkoterski wants to merge 1 commit intoHarbourMasters:mainfrom
mkoterski wants to merge 1 commit intoHarbourMasters:mainfrom
Conversation
mkoterski
force-pushed
the
fix/macos-coreaudio-combobox
branch
from
25ed7a2 to
20fafd5
Compare
macOS uses COREAUDIO as the default audio backend, but the combobox display map in MenuTypes.h only contained SDL and WASAPI. This causes an unordered_map::at crash on first frame draw when the Audio API dropdown tries to render. Fixes the menu crash portion of HarbourMasters#681.
mkoterski
force-pushed
the
fix/macos-coreaudio-combobox
branch
from
20fafd5 to
aa351af
Compare
mkoterski
changed the title
mkoterski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS uses COREAUDIO as the default audio backend, but the combobox display map in MenuTypes.h only contained SDL and WASAPI. This causes an unordered_map::at crash on first frame draw when the Audio API dropdown tries to render.
Fixes the menu crash portion of #681.