Skip to content

Eagerly print test name before execution to expose hanging tests #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Simn merged 2 commits into from
Mar 22, 2026
Merged

Eagerly print test name before execution to expose hanging tests #176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
138f9f7
Initial plan
Copilot Mar 22, 2026
bdc5ba2
Print test name before execution to detect hanging tests
Copilot Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 24 additions & 10 deletions libs/atest/src/atest/Runner.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ class Runner {
if (pattern != null && !StringTools.contains(t.name, pattern)) continue;

totalTests.add(1);
printTestStart(t.name);
try {
// Extract `execute` into a local so the Lua backend
// emits a plain function call instead of a colon-call
Expand Down Expand Up @@ -121,24 +122,24 @@ class Runner {
throw new AssertFailure("No assertions made", null);
}
totalPassed.add(1);
printResult(t.name, true, null);
printTestEnd(true, null);
} catch (e:hxcoro.exceptions.TimeoutException) {
totalFailed.add(1);
final detail = 'timeout after ${t.timeout}ms';
printResult(t.name, false, detail);
printTestEnd(false, detail);
failures.push(' ${c.name}::${t.name} - $detail');
} catch (e:AssertFailure) {
totalFailed.add(1);
final detail = e.pos != null ? '${e.message} at ${e.posToString()}' : e.message;
printResult(t.name, false, detail);
printTestEnd(false, detail);
failures.push(' ${c.name}::${t.name} - $detail');
try {
c.instance.teardown();
} catch (_:Dynamic) {}
} catch (e:Dynamic) {
totalErrors.add(1);
final detail = Std.string(e);
printResult(t.name, false, 'ERROR: $detail');
printTestEnd(false, 'ERROR: $detail');
failures.push(' ${c.name}::${t.name} - ERROR: $detail');
try {
c.instance.teardown();
Expand Down Expand Up @@ -169,12 +170,25 @@ class Runner {
// Output helpers
// ------------------------------------------------------------------

static function printResult(name:String, passed:Bool, ?detail:String) {
if (passed) {
println(' $name ... OK');
} else {
println(' $name ... FAIL: $detail');
}
static function printTestStart(name:String) {
#if sys
Sys.print(' $name ... ');
Sys.stdout().flush();
#elseif js
js.Syntax.code("process.stdout.write(' ' + {0} + ' ... ')", name);
#else
trace(' $name ...');
#end
}

static function printTestEnd(passed:Bool, ?detail:String) {
#if sys
Sys.println(passed ? 'OK' : 'FAIL: $detail');
#elseif js
js.Syntax.code("console.log({0})", passed ? 'OK' : 'FAIL: ' + detail);
#else
trace(passed ? 'OK' : 'FAIL: $detail');
#end
}

static function println(msg:String) {
Expand Down
Loading