chore: remove redundant compose Exclude annotation#469
Merged
Conversation
hopeman15
force-pushed
the
chore/remove-compose-exclude-annotation
branch
from
367eef7 to
cd0cc5f
Compare
The custom @exclude annotation was a workaround for kover not honoring @Preview in its annotation excludes filter. The current kover config already excludes preview composables via annotatedBy("*Preview"), so the custom annotation is redundant and was never actually wired into the kover excludes filter. Closes #67
hopeman15
force-pushed
the
chore/remove-compose-exclude-annotation
branch
from
cd0cc5f to
f70cabb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@Excludeannotation (and its 3 declaration files) used to mark@Preview @Composablepreviews so kover would skip them.kover { reports { filters { excludes { ... } } } }block inbuild.gradle.ktsonly references*BuildConfigand*Preview. Confirmed by inspecting per-modulereportDebug.xmlonmain: previews already appear there, so removing@Excludeis purely a noop cleanup.annotatedBy("*Preview")is the supported path in current kover (0.8.3).Closes #67