fix: resolve all golangci-lint v2 violations - #51
Merged
Conversation
Fix 24 lint issues surfaced by the v2 migration: - exhaustive (5): add missing enum switch cases for PhaseDealerTurn, Empty, Revealed, Playing, NumCategories - gofmt (60 files): normalize line endings across all Go source files - gosec (7): annotate safe integer conversions (G115) and bounds-guaranteed slice accesses (G602) with nolint - prealloc (4): preallocate slices with known capacity in minesweeper, twofortyeight, and typingtest view functions - staticcheck (5): use fmt.Fprintf instead of WriteString+Sprintf, apply De Morgan's law, convert if/else chain to tagged switch All 24 issues resolved. golangci-lint run ./... reports 0 issues. Co-Authored-By: Claude <noreply@anthropic.com>
- CLAUDE.md: wrap long lines to fix MD013 (line-length) - README.md: add spaces to table separator for MD060 (table-column-style) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 24 lint issues surfaced by the golangci-lint v2 migration in PR #50, plus 6 pre-existing markdownlint violations:
PhaseDealerTurn,Empty,Revealed,Playing,NumCategoriesfmt.Fprintfinstead ofWriteString(fmt.Sprintf(...)), apply De Morgan's law, convert if/else chain to tagged switchgolangci-lint run ./...reports 0 issues.markdownlint-cli2reports 0 errors.Test plan
go build ./...passesgo test ./...passes (all 18 test suites)golangci-lint run ./...reports 0 issuesmarkdownlint-cli2 "**/*.md"reports 0 errorsCo-Authored-By: Claude noreply@anthropic.com