Fixed issue regarding stylist ui behavior and restrictions.#3379
Open
MrKeiKun wants to merge 1 commit into
Open
Fixed issue regarding stylist ui behavior and restrictions.#3379MrKeiKun wants to merge 1 commit into
MrKeiKun wants to merge 1 commit into
Conversation
dastgirp
approved these changes
Sep 1, 2025
hemagx
requested changes
May 24, 2026
hemagx
left a comment
hemagx
left a comment
Contributor
There was a problem hiding this comment.
Overall the PR is fine, the commit message however isn't please explain the change of restriction in the commit message, be verbose i need to understand what happened just from reading the commit message not just the code.
…t restrictions Unlike all other interactive UI panels (Refine, Lapine, Grade, Reform, Enchant), the Stylist UI had no server-side open/close flag, meaning its close handler was a stub that did nothing, style-change packets were never guarded against being processed without the UI open, player movement was not blocked while using it, and it was absent from all pc_cant_act macros. This adds a stylist_ui flag to map_session_data.state (set on open, cleared on close), guards both style-change packet handlers to reject requests when the UI is not open server-side, blocks movement in unit_can_move, adds stylist_ui to all pc_cant_act macros, and introduces pc_cant_act_except_stylist to match the pattern of the other UIs. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
MrKeiKun
force-pushed
the
fix-2102-stylist-ui
branch
from
b9ac7fb to
74f1c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Players are properly restricted from movement and item usage when the stylist UI is active.
Issues addressed: #2102