Add libconfig import support to remaining conf files#3409
Open
MrKeiKun wants to merge 1 commit into
Open
Conversation
MrKeiKun
force-pushed
the
fix/62-libconfig-import-support
branch
from
62cf4ca to
3505112
Compare
MrKeiKun
force-pushed
the
fix/62-libconfig-import-support
branch
from
d26954e to
d4106c9
Compare
hemagx
requested changes
May 23, 2026
Adds 'import' directive support to the conf files that previously lacked it: network.conf, battlegrounds.conf, channels.conf, clans.conf, groups.conf, atcommand.conf, plugins.conf, and the HPM plugin list. Also adds import-tmpl/ stub files for each so users have a ready-made import target. The bg_config_read and read_channels_config functions are updated to accept a filename parameter directly instead of delegating to a separate _from_file helper. The pc_groups config pool is changed from a fixed-size array to a VECTOR so import depth is no longer artificially capped. Signed-off-by: Lorenzo Buitizon <the.keikun@gmail.com>
MrKeiKun
force-pushed
the
fix/62-libconfig-import-support
branch
from
d4106c9 to
8b0c9be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Adds the
import:override mechanism to conf files that were missing it, consistent with the existing pattern used inmap-server.conf,char-server.conf, etc.conf/atcommand.conf— added import lookup inatcommand_config_read()conf/groups.conf— refactoredread_config()inpc_groups.cto use a static config pool so all configs stay alive until inheritance resolution andatcommand->load_groups()completeconf/channels.conf— splitread_channels_config()into a_from_file()helper with recursive import supportconf/battlegrounds.conf— same wrapper/helper split patternconf/clans.conf— import recurses withreload=falseto avoid clearing the DB on the secondary fileconf/network.confandconf/api/api_network.conf— added import lookup insocket_net_config_read()(already accepted a filename)conf/plugins.conf— replaced the oldfopenreplace-hack with proper merge support; HPMHooking-first ordering preserved via anis_primaryflagEach modified conf file gets an
import:line pointing toconf/import/<name>.conf, and a corresponding skeleton is added toconf/import-tmpl/.Issues addressed: #62