feat!: support multiple namespaces for the game#16
Closed
imLinguin wants to merge 5 commits into
Closed
Conversation
and more data to json output of platform_versions, also always return namespace data
Ericky14
approved these changes
May 16, 2025
CommandMC
reviewed
May 16, 2025
CommandMC
left a comment
Member
There was a problem hiding this comment.
Changes to metadata mean older versions of legendary will probably fail to read those files. I can try to make this as much backwards compatible as possible if desired.
I'd say do this, yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change that allows games to contain more than one asset per platform - meaning multiple sandboxes aka namespaces.
This involves breaking changes to how metadata.json is stored, as well as additional fields to installed game classes.
Sidecar configs were also separated into per-namespace maps.
Changes to metadata mean older versions of legendary will probably fail to read those files. I can try to make this as much backwards compatible as possible if desired.
Additional remarks:
{platform: [...assets]}object, instead of just versions