Fix download issue for games with large number of savefiles and improve performance#21
Merged
Merged
Conversation
…hen more than 1000 chunks in manifest
Author
|
Any Love? :) @imLinguin @CommandMC |
CommandMC
reviewed
Aug 22, 2025
CommandMC
left a comment
Member
There was a problem hiding this comment.
Feel free to bug us on Discord next time to get things reviewed faster
Author
|
Thanks will do. I applied the nit. |
CommandMC
approved these changes
Aug 22, 2025
Author
|
Thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing with a game that has ~650 savefiles, I noticed that Legendary wasn't downloading any data — the download process completed instantly without actually retrieving any files.
Root Cause
Upon investigation, I discovered that the Epic Games Store (EGS) API limits the number of files returned in the metadata JSON to 1000 entries. For games with many files, such as save-heavy ones, essential files like the manifest chunks were missing from the response due to this limit.
Fix
To resolve this, I:
Enhancements
To improve download performance and reliability:
legendary-gl#709
Possible fix Heroic-Games-Launcher/HeroicGamesLauncher#3708