manager.py: Fix unchanged field being corrupted with file size bytes#49
Open
MateoGonzalezLourido wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnalysisResult defines two separate fields:
unchanged: int — count of unchanged files
unchanged_size: int — total size in bytes of unchanged files
In manager.py, line 254 was writing file sizes into unchanged instead of unchanged_size:
python# Before (incorrect)
analysis_res.unchanged += fm.file_size # mixes byte values into a file count
After
analysis_res.unchanged_size += fm.file_size
This meant any code reading analysis_res.unchanged would get a completely corrupt value (file count + accumulated bytes), and unchanged_size was always left at 0 despite being declared in the dataclass.