Skip to content

fix(ci): resolve baseline failures blocking PRs#7

Closed
HexaField wants to merge 4 commits intomainfrom
fix/ci-baseline-typecheck-errors
Closed

fix(ci): resolve baseline failures blocking PRs#7
HexaField wants to merge 4 commits intomainfrom
fix/ci-baseline-typecheck-errors

Conversation

@HexaField
Copy link
Copy Markdown
Owner

Summary

  • fix the baseline client/server TypeScript issues reproduced from the current CI workflow
  • make workspace/dashboard/chat code paths type-safe again without reintroducing removed behavior
  • allow server/test startup in CI environments where node-pty native bindings are unavailable until terminal sessions are actually used
  • align package test scripts so workspaces with zero tests do not fail the root test command immediately

What changed

  • added specs/ci-baseline-fix.md before implementation
  • fixed WorkspaceView.tsx stale tab/type narrowing errors and related client type issues surfaced by pnpm run check
  • cleaned up stale/unused imports, values, and test fixtures that were breaking strict TS checks
  • restored/exported getLastMessages for dashboard coverage and fixed OrgSummary test data
  • changed server bootstrap env fallback handling for empty gateway URL/token values
  • lazy-loaded node-pty inside the terminal manager so app startup does not crash in CI when the native module is unavailable
  • updated packages/core and packages/server test scripts to vitest run --passWithNoTests

Verification

  • pnpm run check
  • pnpm run certs && pnpm run build
  • pnpm run test progressed past the previous immediate no-tests failure, but local Playwright remains blocked by a separate EADDRINUSE ::1:5899 webserver/runtime issue

Scope

This PR is intentionally limited to CI/CD baseline failures and related startup/check fixes.

- Remove unused thread-store imports from WorkspaceView.tsx
- Remove stale 'threads' sidebar Match branch
- Add type-safe active-tab memo helpers for file-viewer rendering
- Update workspace tests to match current SidebarTab/SIDEBAR_TABS contract
- Restore pnpm check to passing state

Fixes pre-existing CI baseline failures unrelated to feature PRs.
@HexaField
Copy link
Copy Markdown
Owner Author

Duplicate of #6 — already merged.

@HexaField HexaField closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant