fix(ci): resolve baseline failures blocking PRs#7
Closed
Conversation
- Remove unused thread-store imports from WorkspaceView.tsx - Remove stale 'threads' sidebar Match branch - Add type-safe active-tab memo helpers for file-viewer rendering - Update workspace tests to match current SidebarTab/SIDEBAR_TABS contract - Restore pnpm check to passing state Fixes pre-existing CI baseline failures unrelated to feature PRs.
Owner
Author
|
Duplicate of #6 — already merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-ptynative bindings are unavailable until terminal sessions are actually usedWhat changed
specs/ci-baseline-fix.mdbefore implementationWorkspaceView.tsxstale tab/type narrowing errors and related client type issues surfaced bypnpm run checkgetLastMessagesfor dashboard coverage and fixedOrgSummarytest datanode-ptyinside the terminal manager so app startup does not crash in CI when the native module is unavailablepackages/coreandpackages/servertest scripts tovitest run --passWithNoTestsVerification
pnpm run check✅pnpm run certs && pnpm run build✅pnpm run testprogressed past the previous immediate no-tests failure, but local Playwright remains blocked by a separateEADDRINUSE ::1:5899webserver/runtime issueScope
This PR is intentionally limited to CI/CD baseline failures and related startup/check fixes.