[CHORE/#665] GitHub Secrets Cleanup and CI/CD Workflow Security Improvements#666
Merged
[CHORE/#665] GitHub Secrets Cleanup and CI/CD Workflow Security Improvements#666
Conversation
- Replaced `echo` with `printf "%s"` to prevent issues with special characters in secrets. - Removed unnecessary conditional checks for the existence of secrets. - Standardized secret environment variable names across different workflows.
angryPodo
requested review from
Daljyeong,
Hyobeen-Park,
nahy-512 and
nhyeonii
and removed request for
a team
Member
Author
|
해당 브랜치로 QA Test 통과했습니다. |
nahy-512
approved these changes
Feb 1, 2026
Member
nahy-512
left a comment
nahy-512
left a comment
There was a problem hiding this comment.
LGTM🚀
LOCAL_PROPERTIES 시크릿키가 있는데 다른 URL이나 Id가 필요한가 싶었는데, 이번에 정리해주신 거군요👍🏻
nhyeonii
approved these changes
Feb 1, 2026
Collaborator
nhyeonii
left a comment
nhyeonii
left a comment
There was a problem hiding this comment.
노션과 함께 확인 완료했습니다!! 고생하셨습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
GitHub Secrets 정리
FIREBASE_CLI_TOKEN,FIREBASE_APP_ID_RELEASE,DEV_BASE_URL등 미사용/중복 시크릿을 삭제Workflow 보안 개선
printf또는 파이프라인(|) 방식으로 변경pr_checker.yml에서 불필요한if조건문을 제거하고 로직을 간소화Uncompleted Tasks 😅
To Reviewers 📢
이번 PR은 코드 변경 없이 GitHub Actions 설정만 변경되었습니다. 그리고 저 이외에도 문제상황 발생시 복구 프로세스를 위해서 안드로이드 노션내에 백업과 백업방법 문서를 제작했습니다. 내일 있을 회의에서 더 자세하게 말씀드릴게요!