Skip to content

ask option refactoring #20274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlocab merged 1 commit into from
Jul 18, 2025
+3 −2
Merged

ask option refactoring #20274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Library/Homebrew/upgrade.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,9 @@ def self.upgrade_dependents(deps, formulae,
#{skipped * "\n "}
EOS
end

upgradeable.reject! { |f| FormulaInstaller.installed.include?(f) }

# Print the upgradable dependents.
if upgradeable.blank?
ohai "No outdated dependents to upgrade!" unless dry_run
Expand All @@ -375,8 +378,6 @@ def self.upgrade_dependents(deps, formulae,
puts formulae_upgrades.join(", ")
end

upgradeable.reject! { |f| FormulaInstaller.installed.include?(f) }

return if upgradeable.blank?

unless dry_run
Expand Down
Loading