Skip to content

test: disable return false handling #22147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyuraku wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −3
Open

test: disable return false handling #22147

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27fbc55
Disable warning for `return false` in test, suggest using `raise` ins…
hyuraku May 6, 2026
77c0e47
Remove support for returning false in tests, enforce raising exceptio…
hyuraku May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Library/Homebrew/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,12 @@
ENV.setup_build_environment(formula:, testing_formula: true)
Pathname.activate_extensions!

# tests can also return false to indicate failure
run_test = proc do |_|
# TODO: Replace proc usage with direct `formula.run_test` when removing this.
# Also update formula.rb 'TODO: replace `returns(BasicObject)` with `void`'
if formula.run_test(keep_tmp: args.keep_tmp?) == false
require "utils/output"
Utils::Output.odeprecated "`return false` in test", "`raise \"<reason for failure>\"`"
raise "test returned false"
Utils::Output.odisabled "`return false` in test", "`raise \"<reason for failure>\"`"
Copy link
Copy Markdown
Contributor Author

@hyuraku hyuraku May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to handle this in the follow-up PR that removes the proc wrapper. Adding caller: here is tricky because of define_method, so a redesign later will be cleaner.

Comment thread
MikeMcQuaid marked this conversation as resolved.
end
Comment thread
MikeMcQuaid marked this conversation as resolved.
end
if args.debug? # --debug is interactive
Expand Down
Loading