Move away from RSpec's described_class

[issyl0]

---

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
• Have you written new tests (excluding integration tests) for your changes? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

---

• AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

When we moved away from using the RuboCop autocorrections for described_class replacements with class names everywhere, I used Copilot with Claude Opus 4.7 in Agent mode to make the changes in commit adf7123 to add let(:klass) { Foo } and replace described_class with klass in all the places.

---

• A follow-up from sorbet: Add RSpec shims and typecheck some tests #22205 (comment), so that Sorbet typechecking of tests can be more thorough.

[MikeMcQuaid]

Sorry to be that guy: now I'm actually looking at the diff, I kinda hate it 😭.

Could we do something like a type alias or e.g. test_alias = Homebrew::API::Cask::CaskStructGenerator to have RSpec handle this better with Sorbet while avoiding the excessive repetition?

[issyl0]

Sorry to be that guy: now I'm actually looking at the diff, I kinda hate it 😭.

Hah, it is quite a lot of diff.

Could we do something like a type alias or e.g. test_alias = Homebrew::API::Cask::CaskStructGenerator to have RSpec handle this better with Sorbet while avoiding the excessive repetition?

To avoid the excessive repetition let(:klass) { Homebrew::Api::Cask::CaskStructGenerator } seems to work, so we can use klass everywhere, and if the name ever changes then there's only a few places to update?

[MikeMcQuaid]

To avoid the excessive repetition let(:klass) { Homebrew::Api::Cask::CaskStructGenerator } seems to work, so we can use klass everywhere, and if the name ever changes then there's only a few places to update?

Works for me!

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

[MikeMcQuaid]

Looks good when 🟢! Don't need another review, just self-merge whenever no conflicts. Another option: do a partial merge with conflicting files removed and address conflicts in another batch to make it easier to get this landed.

[issyl0]

Sorry, had this on my list to get back to, but then 😅🔥 - thanks for finishing it off!