Check bundle formula link status#22412
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends brew bundle check to validate whether installed formulae match the Brewfile’s expected link/unlink state (including implicit expectations), aligning check behavior with what brew bundle install would do and adding spec coverage for the new failure mode.
Changes:
- Add link-status evaluation to formula “installed and up-to-date” checking and provide a specific failure message for link mismatches.
- Refactor link/unlink decision logic into a shared helper used by both checking and install-time link state changes.
- Add
bundle checkspecs covering non-verbose,--verbose, and--installscenarios for link-status mismatches.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Library/Homebrew/bundle/brew.rb |
Adds link-status checking logic and refactors expected link behavior into shared helpers used by both check and install link/unlink operations. |
Library/Homebrew/test/cmd/bundle/check_subcommand_spec.rb |
Adds test coverage for formula link-status mismatches across check modes (default, --verbose, --install). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Ensure `brew bundle check` catches formulae with wrong links - Match implicit link expectations used by `brew bundle install` - Cover `check`, `check --verbose` and `check --install`
MikeMcQuaid
force-pushed
the
bundle-check-link-status
branch
from
97a8831 to
7eb081f
Compare
p-linnane
approved these changes
May 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew bundle checkcatches formulae with wrong linksbrew bundle installcheck,check --verboseandcheck --installbrew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex 5.5 xhigh with local review and testing.