Skip to content

Stop vendoring brew.sh theme#2219

Merged
MikeMcQuaid merged 1 commit into
mainfrom
redesign-homebrew-website
Jun 8, 2026
Merged

Stop vendoring brew.sh theme#2219
MikeMcQuaid merged 1 commit into
mainfrom
redesign-homebrew-website

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Use the shared brew.sh theme assets by URL to avoid duplicated files.
  • Keep only the formulae layouts and includes that this site needs.
  • Drop feed and blog-only files because formulae pages do not publish posts.
  • Remove jekyll-remote-theme so builds do not fetch a remote theme.
  • Refresh the lockfile for the simplified Jekyll dependency set.

- Use the shared `brew.sh` theme assets by URL to avoid duplicated files.
- Keep only the formulae layouts and includes that this site needs.
- Drop feed and blog-only files because formulae pages do not publish posts.
- Remove `jekyll-remote-theme` so builds do not fetch a remote theme.
- Refresh the lockfile for the simplified Jekyll dependency set.
Copilot AI review requested due to automatic review settings June 8, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR de-vendors the brew.sh theme from formulae.brew.sh by switching to shared theme assets hosted on https://brew.sh, and removes blog/feed-related layouts/includes that aren’t used by the formulae site. It also updates the lockfile to reflect the simplified Jekyll dependency set.

Changes:

  • Load shared brew.sh CSS and image assets via absolute URLs and update the CSP allowlist accordingly.
  • Remove vendored theme assets (SCSS + SVGs) and drop unused blog/feed layouts/includes.
  • Refresh Gemfile.lock (notably io-event patch update).

Reviewed changes

Copilot reviewed 9 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Gemfile.lock Lockfile refresh (includes io-event patch bump).
assets/img/linuxbrew.svg Remove vendored theme image.
assets/img/homebrew.svg Remove vendored theme image.
assets/img/homebrew-social-card.svg Remove vendored theme image.
assets/img/forkme_right_gray_6d6d6d.svg Remove vendored theme image.
assets/img/brewtestbot.svg Remove vendored theme image.
assets/img/brewsci.svg Remove vendored theme image.
assets/img/brew.svg Remove vendored theme image.
assets/img/apple-touch-icon.svg Remove vendored theme image.
assets/css/style.scss Remove vendored theme stylesheet.
_sass/pygments.scss Remove vendored Pygments styles (theme-provided styling now expected externally).
_layouts/post.html Remove blog post layout (not used by formulae site).
_layouts/index.html Remove homepage/blog-oriented layout (not used by formulae site).
_layouts/home.html Remove blog/home wrapper layout (not used by formulae site).
_layouts/base.html Point CSS/icons/logo/fork ribbon at brew.sh and adjust CSP; remove feed injection.
_includes/newsletter.html Remove newsletter embed include (blog-only).
_includes/feed.html Remove feed meta include.
_config.yml Switch default SEO image and logo to brew.sh hosted assets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread _layouts/base.html
Comment thread _layouts/base.html
@MikeMcQuaid MikeMcQuaid enabled auto-merge June 8, 2026 13:56
@MikeMcQuaid MikeMcQuaid merged commit 0d389d1 into main Jun 8, 2026
17 checks passed
@MikeMcQuaid MikeMcQuaid deleted the redesign-homebrew-website branch June 8, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants