Add Formula "nyancat" by yoshida-mediba · Pull Request #43289 · Homebrew/legacy-homebrew

yoshida-mediba · 2015-08-26T09:03:33Z

No description provided.

bfontaine · 2015-08-26T09:24:58Z

Library/Formula/nyancat.rb

Please remove these comments.

MikeMcQuaid · 2015-08-26T22:11:50Z

The test is failing, would be good to work out where it's trying to write to that's invalid: http://bot.brew.sh/job/Homebrew%20Pull%20Requests/32193/version=yosemite/testReport/junit/brew-test-bot/yosemite/test_nyancat/

yoshida-mediba · 2015-08-27T02:46:01Z

It is similar to the sl command.
Fixed by reference to.

https://github.com/Homebrew/homebrew/blob/master/Library/Formula/sl.rb

MikeMcQuaid · 2015-08-27T11:03:36Z

Library/Formula/nyancat.rb

Please use the make install and submit a patch to allow a custom prefix: https://github.com/klange/nyancat/blob/master/Makefile#L35-L37

fix now
klange/nyancat#34

yoshida-mediba · 2015-08-28T01:39:42Z

install src/nyancat /usr/local/Cellar/nyancat/0752/bin/nyancat
install: /usr/local/Cellar/nyancat/0752/bin/nyancat: No such file or directory
make: *** [install] Error 71

😞

bfontaine · 2015-08-28T07:35:13Z

Library/Formula/nyancat.rb

Use "--frame", "1".

bfontaine · 2015-08-28T07:37:03Z

@yoshida-mediba I guess it should be install -d instead of install. -d creates the missing parent directories.

yoshida-mediba · 2015-08-28T09:58:11Z

Fixit!!

bfontaine · 2015-08-28T10:06:25Z

Library/Formula/nyancat.rb

Please add a comment explaining why this is necessary.

And use a PR url patch URL instead of a compare, thanks.

yoshida-mediba · 2015-08-31T02:06:50Z

FIxit!!

bfontaine · 2015-08-31T07:10:23Z

Library/Formula/nyancat.rb

You can remove this line; Homebrew gets it from the URL.

yoshida-mediba · 2015-09-03T05:59:27Z

Fix!!

bfontaine · 2015-09-03T07:33:13Z

Thank you @yoshida-mediba! 🎉

For future reference, the preferred commit message format for new formulae is “name version (new formula)”, e.g. “nyancat 1.4.4 (new formula)”.

yoshida-mediba changed the title ~~Nyancat Terminal~~ Add Formula "nyancat" Aug 26, 2015

bfontaine added the new formula label Aug 26, 2015

bfontaine reviewed Aug 26, 2015
View reviewed changes

Library/Formula/nyancat.rb Outdated

Copy link
Copy Markdown

Contributor

bfontaine Aug 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these comments.

MikeMcQuaid reviewed Aug 27, 2015
View reviewed changes

bfontaine reviewed Aug 28, 2015
View reviewed changes

Library/Formula/nyancat.rb Outdated

Copy link
Copy Markdown

Contributor

bfontaine Aug 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "--frame", "1".

bfontaine reviewed Aug 28, 2015
View reviewed changes

bfontaine reviewed Aug 31, 2015
View reviewed changes

Library/Formula/nyancat.rb Outdated

Copy link
Copy Markdown

Contributor

bfontaine Aug 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line; Homebrew gets it from the URL.

Nyancat Terminal

c095a74

bfontaine closed this in 78aa4f6 Sep 3, 2015

Homebrew locked and limited conversation to collaborators Jul 10, 2016

Uh oh!

Conversation

yoshida-mediba commented Aug 26, 2015

Uh oh!

bfontaine Aug 26, 2015

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid commented Aug 26, 2015

Uh oh!

yoshida-mediba commented Aug 27, 2015

Uh oh!

MikeMcQuaid Aug 27, 2015

Choose a reason for hiding this comment

Uh oh!

yoshida-mediba Aug 28, 2015

Choose a reason for hiding this comment

Uh oh!

yoshida-mediba commented Aug 28, 2015

Uh oh!

bfontaine Aug 28, 2015

Choose a reason for hiding this comment

Uh oh!

bfontaine commented Aug 28, 2015

Uh oh!

yoshida-mediba commented Aug 28, 2015

Uh oh!

bfontaine Aug 28, 2015

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Aug 28, 2015

Choose a reason for hiding this comment

Uh oh!

yoshida-mediba commented Aug 31, 2015

Uh oh!

bfontaine Aug 31, 2015

Choose a reason for hiding this comment

Uh oh!

yoshida-mediba commented Sep 3, 2015

Uh oh!

bfontaine commented Sep 3, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants