Skip to content

make test_clip respect revisions in a0f39c23 and f7c47819#74

Merged
ClashLuke merged 1 commit into
HomebrewML:mainfrom
alexjwilliams:fix-test_clip
Aug 3, 2025
Merged

make test_clip respect revisions in a0f39c23 and f7c47819#74
ClashLuke merged 1 commit into
HomebrewML:mainfrom
alexjwilliams:fix-test_clip

Conversation

@alexjwilliams

Copy link
Copy Markdown
Contributor

As the title says. We forgot to update test_clip.py after we made those revisions. The current state of the tests is the same as in #73:

FAILED test/test_clip.py::test_clip[128-2-Muon] - assert False
FAILED test/test_clip.py::test_clip[128-2-MuonLaProp] - assert False
FAILED test/test_clip.py::test_clip[128-2-ForeachNewtonPSGDLRA] - ValueError: Hessian approximation requires a closure.
FAILED test/test_clip.py::test_clip[128-2-ForeachMuon] - assert False
FAILED test/test_clip.py::test_clip[128-2-ForeachCachedNewtonPSGD] - ValueError: Hessian approximation requires a closure.
FAILED test/test_clip.py::test_clip[128-2-NewtonPSGDLRA] - ValueError: Hessian approximation requires a closure.
FAILED test/test_clip.py::test_clip[128-2-NewtonHybrid2PSGDLRA] - ValueError: Hessian approximation requires a closure.
FAILED test/test_clip.py::test_clip[128-2-NewtonHybrid2PSGDKron] - ValueError: Hessian approximation requires a closure.
FAILED test/test_clip.py::test_clip[128-2-NewtonPSGDKron] - ValueError: Hessian approximation requires a closure.

@ClashLuke

Copy link
Copy Markdown
Member

Thank you for fixing the test mismatch! I'll do the hessian approximation thing as soon as possible.

@ClashLuke ClashLuke merged commit 14e68a8 into HomebrewML:main Aug 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants