SUBSTRING length caused issues with compiling on Indigo#4
Open
fredrikbaberg wants to merge 2 commits into
Open
SUBSTRING length caused issues with compiling on Indigo#4fredrikbaberg wants to merge 2 commits into
fredrikbaberg wants to merge 2 commits into
Conversation
Make my fork up to date with remote master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure this is correct, so would be good if someone else could check it.
When I tried to catkin build (I'm using catkin_tools) I got an issue that:
I'm not sure if there were some specific reason 200 was used for length, but setting it to -1 should use the rest of the string (according to https://cmake.org/cmake/help/v3.0/command/string.html).