fix: initialize time series before concurrent chunk writes - #310
Open
krowvin wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Chunked writes to a new time series currently submit every chunk concurrently. The integration matrix on #309 exposed database errors during those writes against latest-dev, leaving partially stored data and causing the next readback test to fail too.
This change completes the first chunk before submitting the remaining chunks concurrently, so the series creation transaction can finish first. It also waits for and checks all multi-series futures, then raises an error naming every failed series instead of printing the errors and returning success. Successfully stored series are not rolled back. The existing integration assertions remain unchanged, and no retry policy or matrix exclusions were added.
Validation:
This is a separate fix from the Release Please migration in #309. Reviewers should note the intentional error-handling correction: callers of store_multi_timeseries_df now receive RuntimeError when one or more series cannot be stored, rather than silent partial success.
Verified backend results
At commit 8159b4f: