Conversation
Hec_zloadcache, Hec_zerror, Hec_zcopyFile
Hec_zopen6, Hec_zopen7, Hec_zopen
removing testVerticalDatum_f.f90
add utility check_jni.py, used to compare Heclib.java JNI calls to C JNI calls.
|
ktarbet
marked this pull request as ready for review
August 15, 2025 22:05
perrymanmd
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request removes several un-used JNI methods. Un-used is defined as not referenced in the hec-monolith java project version 6.0.1.
For example Hec_fortranWind.c was removed.
note: The JNI methods are prefixed with Hec_.
resolves #303
progress on #304
Some related Fortran methods were also removed if they were only used to support the JNI code.
This was manually tested against Java code (hec-monolith 6.0 )