Handle additional types in ztypeName - #328
Merged
Merged
Conversation
|
ktarbet
approved these changes
Nov 3, 2025
Contributor
|
note: The main branch of DSS now is only for DSS Version 7 support. You may wish to put this same change into the master branch if you need version 6 support. |
Contributor
Author
|
@ktarbet What’s the standard way to apply the same change to two branches? Do I need to fork the repo and make the changes separately on each branch? |
ktarbet
pushed a commit
that referenced
this pull request
Nov 6, 2025
* Add abbreviations for few data types * Add handling for additional data types in ztypeName
Contributor
|
Cherry pick like this: (I did this so I could practice/learn). git clone https://github.com/HydrologicEngineeringCenter/hec-dss.git
cd hec-dss
git checkout -b cherry-pick-type-names
git cherry-pick 2724d2d
git push --set-upstream origin cherry-pick-type-names
PR is here: #332 |
ktarbet
added a commit
that referenced
this pull request
Nov 6, 2025
* Add abbreviations for few data types * Add handling for additional data types in ztypeName Co-authored-by: Gyan Basyal <gyanBasyalz@gmail.com> note: This is a courtesy (learning) cherry pick to master branch (DSS Version 6 enabled.) Support for this branch (master) will need to be community support in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zTypeName function currently returns DATA_TYPE_UNDEFINED (abbreviated as "UDF") for grid, image, and file record types. This patch adds proper handling for these record types.