fix(us): fail-fast timeout on findMyCar location request - #1220
Draft
blka wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Do we have evidence of this happening? |
blka
marked this pull request as draft
July 7, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HyundaiBlueLinkApiUSA._get_vehicle_locationcalledself.session.get(url, headers=headers)with the session default timeout(connect=10, read=30). If thercs/rfc/findMyCarendpoint hangs, the coordinator update blocks for up to 30s on read timeout.The method already has
try/except ExceptionreturningNoneon failure, and the coordinator already falls back to cachedvehicleLocationwhen location isNone. So this is purely a fail-faster concern, not a correctness fix.Fix
Pass a per-call timeout on the findMyCar request only:
connect=5(vs session 10),read=10(vs session 30).session.getcalls in the file keep the session default.requests.exceptions.Timeoutis caught by the existingexcept Exception→ returnsNone→ coordinator uses cachedvehicleLocation.Tests
New
tests/us_findmycar_timeout_test.py(2 tests): assertssession.getis called withtimeout=(5, 10); asserts aTimeoutexception results inNone(graceful). Full suite green. Ruff + pre-commit green.